Skip to content

Conversation

@nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Jan 9, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2020
@nnegrey nnegrey marked this pull request as ready for review January 9, 2020 20:36
@nnegrey nnegrey requested a review from a team January 9, 2020 20:36
Comment on lines +49 to +50
requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS");
requireEnvVar("GOOGLE_CLOUD_PROJECT");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine the project is needed, but G_A_C shouldn't be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V3 of translate became a resourceful API and requires credentials now.

Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a README.me ?

@nnegrey nnegrey merged commit acd0ce4 into master Jan 21, 2020
@nnegrey nnegrey deleted the translate-text branch January 21, 2020 22:20
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
* translate: add basic translation samples

* Update pom.xml

* bump timeout for batch call

* Update readme to include info about v3 samples and basic vs advanced links

* Update blunderbuss.yml

Co-authored-by: Kurtis Van Gent <[email protected]>
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
* translate: add basic translation samples

* Update pom.xml

* bump timeout for batch call

* Update readme to include info about v3 samples and basic vs advanced links

* Update blunderbuss.yml

Co-authored-by: Kurtis Van Gent <[email protected]>
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
* translate: add basic translation samples

* Update pom.xml

* bump timeout for batch call

* Update readme to include info about v3 samples and basic vs advanced links

* Update blunderbuss.yml

Co-authored-by: Kurtis Van Gent <[email protected]>
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
* translate: add basic translation samples

* Update pom.xml

* bump timeout for batch call

* Update readme to include info about v3 samples and basic vs advanced links

* Update blunderbuss.yml

Co-authored-by: Kurtis Van Gent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants