fix(compute-samples): fixed flaky firewall rule deletion #6609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
averikitsch
approved these changes
Jan 10, 2022
| Assert.assertEquals(500, client.get(PROJECT_ID, FIREWALL_RULE_CREATE).getPriority()); | ||
| stdOut.close(); | ||
| System.setOut(null); | ||
| ByteArrayOutputStream stdOut = new ByteArrayOutputStream(); |
Contributor
There was a problem hiding this comment.
nit: a more consistent way would be to execute this in a before or beforeAll method.
Contributor
Author
There was a problem hiding this comment.
beforeAll() has the mechanism to clear stdout before every function.
testPatchFirewallRule() needed this as it is called from setUp() directly (to test before GCE Enforcer renders this test invalid).
| // Clear system output to not affect other tests. | ||
| // Refrain from setting out to null as it will throw NullPointer in the subsequent tests. | ||
| stdOut.close(); | ||
| System.setOut(new PrintStream(new ByteArrayOutputStream())); |
Contributor
There was a problem hiding this comment.
nit: a safer way is to save stdout and then set to previous stdout
Contributor
Author
There was a problem hiding this comment.
Thanks Averi. Will include this change.
Sita04
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sita04
added a commit
that referenced
this pull request
Jan 24, 2022
* fix(compute-samples): fixed flaky firewall rule deletion * fix(compute-samples): fixed flaky firewall rule deletion * fix(compute-samples): fixed NullPointer caused by Sysout set to null * docs(compute-samples): included review comments * docs(compute-samples): included review comments * docs(compute-samples): lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6608
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only