ESLint: Node 8+ WARNINGs --> ERRORs #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
September 20, 2019 13:21
ace-n
requested review from
djmailhot,
gguuss,
grant and
jsimonweb
as code owners
fhinkel
approved these changes
Sep 24, 2019
djmailhot
reviewed
Sep 24, 2019
Contributor
djmailhot
left a comment
djmailhot
left a comment
There was a problem hiding this comment.
Files reviewed:
- functions/scheduleinstance/*
The updated code does not behave as expected. Please take a look at the in-line comment
jsimonweb
approved these changes
Sep 24, 2019
Contributor
jsimonweb
left a comment
jsimonweb
left a comment
There was a problem hiding this comment.
functions/spanner changes LGTM
djmailhot
approved these changes
Sep 25, 2019
Contributor
djmailhot
left a comment
djmailhot
left a comment
There was a problem hiding this comment.
LGTM functions/scheduleinstance/*
added 4 commits
September 25, 2019 12:18
This was referenced Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to break this up piece-wise by commit - so if a sample you own is affected, feel free to review only the relevant commit(s).