-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(deps): update dependency got to v10 #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fhinkel
merged 1 commit into
GoogleCloudPlatform:master
from
renovate-bot:renovate/got-10.x
Mar 24, 2020
Merged
fix(deps): update dependency got to v10 #1557
fhinkel
merged 1 commit into
GoogleCloudPlatform:master
from
renovate-bot:renovate/got-10.x
Mar 24, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhinkel
approved these changes
Dec 3, 2019
Contributor
|
@michaelawyu Could you check why this update breaks |
2273bfa to
ff09d19
Compare
ff09d19 to
bafc77c
Compare
Contributor
|
ping @michaelawyu |
16d3df4 to
de1d6af
Compare
de1d6af to
e63f540
Compare
e63f540 to
5167488
Compare
5167488 to
134aee4
Compare
134aee4 to
fed96e1
Compare
ac44734 to
fc25afd
Compare
fc25afd to
60df008
Compare
Contributor
|
The new version of |
60df008 to
7476235
Compare
7476235 to
4d1c987
Compare
4d1c987 to
bd42a4b
Compare
This was referenced Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
This human has signed the Contributor License Agreement.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^9.6.0->^10.0.0^9.6.0->^10.0.0Release Notes
sindresorhus/got
v10.6.0Compare Source
allowGetBodyoption to allow GET requests with payload (#1081)526b4bbv10.5.7Compare Source
acefaa4v10.5.6Compare Source
64aeb4032e609fv10.5.5Compare Source
1f363b9v10.5.4Compare Source
_paginationnot falling back to defaultsff1dba1v10.5.3Compare Source
518d95av10.5.2Compare Source
p-eventdependency8373112v10.5.1Compare Source
453a3a3v10.5.0Compare Source
761c7c6We're looking for feedback on how it works.
v10.4.0Compare Source
@szmarczak/cacheable-lookupdependencyd527daeParseErrors (#1044)2813b73got.stream(...)not throwingReadErrors1f6ca6bv10.3.0Compare Source
17d629afddecabGotRequestMethodTypeScript type (#1017)f02694eReadErrorTypeScript type (#1027)d222164v10.2.2Compare Source
requestoption in normalizedhttpoptions61009b3v10.2.1Compare Source
got.mergeOptions(...)can be assigned to defaults (#1008)1360a1burloption is mutually exclusive with theurlinput argumente0f8aabRetryObject['error']TypeScript types5008bf7@szmarczak/http-timerdependencya1b8ffcv10.2.0Compare Source
electron.netsupport (#995)b2f8ace- See #899 (comment). When the support is removed, you'll still be able to use Got in the Electron main process and in the renderer process through the
electron.remotemodule or if you use Node.js shims.hostnameis not presentdc53747Premature closeerrorsfa60b5fv10.1.0Compare Source
Enhancements
0569d45Fixes
content-lengthheader not being set when using customcontent-type3149340912c2e57bf92f4v10.0.4Compare Source
URLandURLSearchParamstypes (#983)cd4226dJust working around yet another TypeScript bug: DefinitelyTyped/DefinitelyTyped#34960
v10.0.3Compare Source
responseTypeoption (071bf5e)Premature closeandRequest timed outerrors (7b2ccb0)options.pathbackwards-compatible (b3f1ac9)v10.0.2Compare Source
URLandURLSearchParamsglobals (#969)2d5e28dgot.mergeOptions(...)TypeScript type (#953)b962d085a8f461v10.0.1Compare Source
jsonoption withgot.stream.post2ec5c4dv10.0.0Compare Source
We're excited to announce Got 10! 🎉 This release has been in the works for almost a year and has been a major undertaking. Got was fully rewritten in TypeScript, which helped us catch many bugs and will give us more confidence in the codebase going forward. Got is now faster and much more stable. We also fixed a huge amount of bugs. Big thanks to everyone that helped make this release possible. 🙌
If you find Got useful, you might want to sponsor the Got maintainers.
Note: Some HTTP agents like
https-proxy-agentandagentkeepaliveare not compatible with Node.js 10 and hence not compatible with Got as Got takes advantage of some Node.js 10-only APIs.Breaking
633651f- Why: This is so that we can use
stream.pipelinefor more reliable stream handling. Node.js 8 will be out of LTS at the end of this month anyway.urlargument92bc808- Why: To reduce ambiguity. It was not clear from just reading the code what it would default to.
- Migrate:
queryoption tosearchParamsand make it stricterb2236635376216518f0f5- Why: To get closer to the
window.fetchnaming in the browser.- Migrate:
baseUrloption withprefixUrl(#829)0d534ed- Note: We also made it stricter to reduce ambiguity. The Got
urlargument now cannot be prefixed with a slash when this option is used.- Why: We renamed it to make it clear that it doesn't do any URL resolution.
- Migrate:
jsonoption to accept an object instead of a boolean and to only be responsible for the request, not the response (#704)a6a7d5a- Note: You now set the request body in this option instead of the
bodyoption when you want to send JSON. This option also no longer sets the response type to JSON. You either call the.json()method or specify theresponseTypeoption for that.- Why: Many people were confused how
{json: true}worked and they also complained that they could not set the request/response type individually.- Migrate:
responseTypeoption instead ofencodingto get a Buffer (#940)6cc3d9f- Why: Previously, you would pass
{encoding: null}to get a Buffer, but this was confusing. You now use{responseType: 'buffer'}instead.- Tip: You can also use
got(…).buffer();.- Migrate:
POSTautomatically when specifyingbody(#756)e367bdb- Why: We're trying to reduce the amount of magic behavior.
- Migrate:
retries.retryoption was split intoretries.limitandretries.calculateDelayb15ce1d- Migrate:
got(…, { retry: { - retries: 2 + limit: 2 } });got(…, { retry: { - retries: iteration => iteration < 2 + calculateDelay: ({attemptCount}) => attemptCount < 2 } });undefinedinstead ofnullto omit a header (https://github.com/sindresorhus/got#headers)518f0f5- Why: We're trying to reduce the use of
null.- Migrate:
got(…, { headers: { - 'user-agent': null + 'user-agent': undefined } });.fromCacheto.isFromCache(#768)b5e443bstreamoption toisStream518f0f5- Why: To make it clearer that it's a boolean and that it doesn't expect a stream to be passed in.
- Migrate:
user-agentheader (#911)95bed1e-
got/9.6.0 (https://github.com/sindresorhus/got)→got (https://github.com/sindresorhus/got)- Why: Importing package.json to get the version caused a lot of problems. And you should ideally set your own
user-agentheader anyway.got.create()518f0f5- You can achieve the same thing with
got.extend()now.got.mergeInstances()518f0f5- Use
gotInstance.extend(...gotInstances)instead..optionsand.responseproperty (#773)6eaa81b- Migrate:
8eaef94- Note:
got.mergeInstances(...instances)is deprecated. UseinstanceA.extend(instanceB)instead.- Migrate:
Enhancements
- Why: This means we can provide our own type definitions and we can be more confident when working on the Got codebase and produce less bugs.
Huge thanks to @pmmmwh, @LinusU, @vladfrangu, @mastermatt, and everyone else that helped us with this rewrite. 🙌
d5d2e6fcd12351contextoption for storing custom metadata across request and hooks (#777)3bb5aa7e9c01e0maxRedirectsoption (#914)0c505b0b7ead5fmethodRewritingoption (#942)b82358ftough-cookiefor handling cookies (#882)518f0f58874a4500e5fd5beforeRedirecthook (#812)355789692b1005.isFromCacheproperty to the stream API (#768)b5e443btimeoutoption can now be modified in hooksd520a3aprefixUrloption can now be modified in hooks (#867)518f0f5URLSearchParamsinstances mergeable (#734)95c7c2cFixes
afterResponsehook (#775)e2054cdportnot being reset on redirect (#729)ada58610501e00retryoption value when specifying a number (#809)9c04a7cbeforeErrorhook134c9b74faf5c7b0dfc95518f0f5204 No Contentwhen parsing response (#925)518f0f5518f0f5afterResponsehook should triggerbeforeRetryhook (#918)518f0f5518f0f5518f0f5cd11a50Docs
retrybehavior5e6782aprefixUrlbehavior (#943)f008bc9retryoption doesn't work with streams9088866Stream.pipeline()when using the stream API06afb27global-agent(#822)ca8c560TimeoutError.timingsproperty8fa18f496ea75fAll commits
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by WhiteSource Renovate. View repository job log here.