Skip to content

Conversation

@codersasha
Copy link

Replace app engine js compilation step with running ts-node on the app engine server.

As ts-node gains popularity, the benefits of debugging and instrumenting typescript code in real-time justify skipping compilation to JS altogether.

Not sure if this has already been considered. Also note that repo-tools test may not support testing typescript code directly, although many popular typescript testing libraries (e.g. jest) do support this.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 19, 2019
@codersasha
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 19, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Dec 19, 2019

@Sashamor Thanks for the pull request. In our docs, we want to explicitely show how to compile TypeScript sources instead of using ts-node. Thank for understanding.

@fhinkel fhinkel closed this Dec 19, 2019
@codersasha codersasha deleted the sashamor/replace-compilation-with-ts-node branch December 19, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants