Skip to content

Conversation

@JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Feb 17, 2020

The request module is officially deprecated:
https://www.npmjs.com/package/request

This is removing one usage of it, and replacing it with gaxios. Hope is that we can use this as a template for others to make this change as we go along as well.

This change also includes:

  • removing unused supertest package
  • doing a deterministic wait on the host/port, instead of counting on retries

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 25, 2020
@fhinkel fhinkel merged commit f9e24c4 into master Feb 25, 2020
@fhinkel fhinkel deleted the nor1 branch February 25, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants