(Maybe) Fix broken billing sample #1990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
grant
approved these changes
Oct 6, 2020
|
|
||
| const PROJECT_NAME = process.env.GOOGLE_CLOUD_PROJECT; | ||
|
|
||
| const FF_CMD = 'functions-framework'; |
Contributor
There was a problem hiding this comment.
In general we should probably use the absolute path to the binary, not the alias. Might cause fewer issues.
grant
suggested changes
Oct 6, 2020
Contributor
grant
left a comment
grant
left a comment
There was a problem hiding this comment.
Found 1 issue we should fix before maybe merging.
Contributor
Author
|
@grant please merge for me once approved - thanks! |
grant
approved these changes
Oct 7, 2020
ace-n
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1988