Skip to content

feat: add eventarc generic sample #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2020
Merged

feat: add eventarc generic sample #2003

merged 2 commits into from
Oct 12, 2020

Conversation

@grant
Copy link
Contributor

@grant grant commented Oct 10, 2020 •
edited
Loading

  • Adds a generic Eventarc sample
    • Re-uses same setup as other Eventarc samples
    • Logs and returns request headers and body. Deletes auth header (if present).
    • Tests that: headers and body are logged except auth header
  • Tested locally

Fixes #1989

@grant
feat: add eventarc generic sample
f0de850 
Signed-off-by: Grant Timmerman <[email protected]>
@grant grant requested review from grayside and michaelawyu October 10, 2020 04:30
@grant grant requested a review from fhinkel as a code owner October 10, 2020 04:30
@grant grant self-assigned this Oct 10, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 10, 2020
@grant grant added the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 68c1449 into master Oct 12, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2020
@grant grant deleted the grant_eventarc_generic branch October 12, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grayside grayside Awaiting requested review from grayside

@fhinkel fhinkel Awaiting requested review from fhinkel

1 more reviewer

@michaelawyu michaelawyu michaelawyu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grant grant

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eventarc: generic

3 participants

@grant @michaelawyu