Skip to content

chore(functions): remove unused template sample #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2020
Merged

chore(functions): remove unused template sample #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5c2328
chore(functions): remove unused template sample
Oct 22, 2020
b8303a7
Remove pug
Oct 22, 2020
9257c5a
Merge branch 'master' into rm-template
fhinkel Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions functions/helloworld/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,16 +150,3 @@ exports.helloError4 = (req, res) => {
res.status(500).send('I failed you');
// [END functions_helloworld_error]
};

// [START functions_helloworld_template]
const path = require('path');
const pug = require('pug');

// Renders the index.pug
exports.helloTemplate = (req, res) => {
// Render the index.pug file
const html = pug.renderFile(path.join(__dirname, 'index.pug'));

res.send(html).end();
};
// [END functions_helloworld_template]
9 changes: 0 additions & 9 deletions functions/helloworld/index.pug
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions functions/helloworld/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
},
"dependencies": {
"@google-cloud/debug-agent": "^5.0.0",
"escape-html": "^1.0.3",
"pug": "^3.0.0"
"escape-html": "^1.0.3"
},
"devDependencies": {
"@google-cloud/functions-framework": "^1.1.1",
Expand Down
22 changes: 0 additions & 22 deletions functions/helloworld/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,26 +156,4 @@ describe('index.test.js', () => {
});
});
});

describe('functions_helloworld_template helloTemplate', () => {
const PORT = 8085;
let ffProc;

before(() => {
ffProc = startFF('helloTemplate', 'http', PORT);
});

after(async () => {
await ffProc;
});

it('helloTemplate: should render the html', async () => {
const response = await httpInvocation('helloTemplate', PORT);

assert.strictEqual(response.statusCode, 200);
assert.ok(
response.body.includes('<h1>Cloud Functions Template Sample</h1>')
);
});
});
});