Skip to content

chore: fix no-empty lint rule #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2020
Merged

chore: fix no-empty lint rule #2051

merged 2 commits into from
Nov 6, 2020

Conversation

@fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Nov 5, 2020

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2020
@fhinkel fhinkel requested review from bcoe and sofisl November 5, 2020 19:34
@fhinkel fhinkel added the automerge Merge the pull request once unit tests and other checks pass. label Nov 5, 2020
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Nov 5, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Nov 5, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Nov 6, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Nov 6, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@fhinkel fhinkel merged commit db11f7c into master Nov 6, 2020
@fhinkel fhinkel deleted the fhinkel-no-empty branch November 6, 2020 18:04
@snyk-bot snyk-bot mentioned this pull request Mar 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sofisl sofisl sofisl approved these changes

@michaelawyu michaelawyu Awaiting requested review from michaelawyu

@noerog noerog Awaiting requested review from noerog

@bcoe bcoe Awaiting requested review from bcoe

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fhinkel @sofisl