Add KMS samples. #304

jmdobry · 2017-01-27T18:41:46Z

No description provided.

ace-n

LGTM, other than a few minor nits.

ace-n · 2017-01-30T00:48:31Z

kms/keys.js

+    // Gets the IAM policy of a key ring
+    cloudkms.projects.locations.keyRings.getIamPolicy(request, (err, policy) => {
+      if (err) {
+        console.log(err);


Nit: should this be console.error? (If so, apply this comment throughout your PR.)

The problem with console.error is it writes to stderr, and the tests had a problem with that.

ace-n · 2017-01-30T18:22:43Z

kms/keys.js

+
+      request = {
+        // This will be a path parameter in the request URL
+        resource_: `projects/${projectId}/locations/${location}/keyRings/${keyRingName}`,


Wishful thinking: these parameter names (resource_ and resource) are annoyingly similar. (Not that we can really change that... 🙁 )

Yes, I was annoyed too

ace-n · 2017-01-30T18:57:45Z

kms/keys.js

+      if (cryptoKeyVersions.length) {
+        cryptoKeyVersions.forEach((version) => {
+          console.log(`${version.name}:`);
+          console.log(`  Created: ${new Date(version.createTime)}`);


Pedantic nit: should we use tab characters (or other special characters) that are easier to count instead of spaces?

Maybe, but I didn't like how huge the tab characters were when printed to my console. 2 spaces was more reliable.

* fix(build): migrate to using main branch * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.7](https://www.github.com/googleapis/nodejs-datalabeling/compare/v2.2.6...v2.2.7) (2021-08-17) ### Bug Fixes * **build:** migrate to using main branch ([#304](https://www.github.com/googleapis/nodejs-datalabeling/issues/304)) ([8835988](https://www.github.com/googleapis/nodejs-datalabeling/commit/88359888f303d90d27b0449dd811e42dadebc5d2)) * **deps:** google-gax v2.24.1 ([#306](https://www.github.com/googleapis/nodejs-datalabeling/issues/306)) ([ea18b87](https://www.github.com/googleapis/nodejs-datalabeling/commit/ea18b87feff1da34b57decb44fea83b3b371b162)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* fix(build): migrate to using main branch * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.7](https://www.github.com/googleapis/nodejs-datalabeling/compare/v2.2.6...v2.2.7) (2021-08-17) ### Bug Fixes * **build:** migrate to using main branch ([#304](https://www.github.com/googleapis/nodejs-datalabeling/issues/304)) ([8835988](https://www.github.com/googleapis/nodejs-datalabeling/commit/88359888f303d90d27b0449dd811e42dadebc5d2)) * **deps:** google-gax v2.24.1 ([#306](https://www.github.com/googleapis/nodejs-datalabeling/issues/306)) ([ea18b87](https://www.github.com/googleapis/nodejs-datalabeling/commit/ea18b87feff1da34b57decb44fea83b3b371b162)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.3.0](googleapis/nodejs-document-ai@v3.2.1...v3.3.0) (2022-02-22) ### Features * add `symbols` field, and auto-format comments ([ec5edb7](googleapis/nodejs-document-ai@ec5edb7)) * add `symbols` field, and auto-format comments ([ec5edb7](googleapis/nodejs-document-ai@ec5edb7)) * add question_id field in ReviewDocumentOperationMetadata ([#304](googleapis/nodejs-document-ai#304)) ([e10cd03](googleapis/nodejs-document-ai@e10cd03)) * add question_id field in ReviewDocumentOperationMetadata ([#308](googleapis/nodejs-document-ai#308)) ([675aff9](googleapis/nodejs-document-ai@675aff9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v1.6.2...v1.7.0) (2020-03-06) ### Features * deferred client initialization ([#304](https://www.github.com/googleapis/nodejs-cloud-container/issues/304)) ([b1b7080](https://www.github.com/googleapis/nodejs-cloud-container/commit/b1b70806289aea73a6e83d3d33983d05856f21f3)) * export protos in src/index.ts ([acaaeff](https://www.github.com/googleapis/nodejs-cloud-container/commit/acaaeff08ad5505accc15bb496bcd3a29086a5ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [5.0.2](https://www.github.com/googleapis/nodejs-security-center/compare/v5.0.1...v5.0.2) (2020-07-27) ### Bug Fixes * add resource config to v1beta1 ([#307](https://www.github.com/googleapis/nodejs-security-center/issues/307)) ([5d99acf](https://www.github.com/googleapis/nodejs-security-center/commit/5d99acf9dea7a6e2d384ee709678365c769f3d6e)) * correct securitycenter grpc_service_configs, add Node 8 tests ([#302](https://www.github.com/googleapis/nodejs-security-center/issues/302)) ([4e4ec5b](https://www.github.com/googleapis/nodejs-security-center/commit/4e4ec5bbd9623dc952781e80da226320db3906af)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v1.6.2...v1.7.0) (2020-03-06) ### Features * deferred client initialization ([#304](https://www.github.com/googleapis/nodejs-cloud-container/issues/304)) ([b1b7080](https://www.github.com/googleapis/nodejs-cloud-container/commit/b1b70806289aea73a6e83d3d33983d05856f21f3)) * export protos in src/index.ts ([acaaeff](https://www.github.com/googleapis/nodejs-cloud-container/commit/acaaeff08ad5505accc15bb496bcd3a29086a5ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

* feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/nodejs-ai-platform@v1.19.0...v2.0.0) (2022-06-23) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#304) ### Features * add ConvexAutomatedStoppingSpec to StudySpec in aiplatform v1beta1 study.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([#297](googleapis/nodejs-ai-platform#297)) ([1e6dcb6](googleapis/nodejs-ai-platform@1e6dcb6)) * add Examples to Explanation related messages in aiplatform v1beta1 explanation.proto ([#307](googleapis/nodejs-ai-platform#307)) ([c69ac2b](googleapis/nodejs-ai-platform@c69ac2b)) * add IAM policy to aiplatform_v1beta1.yaml ([#308](googleapis/nodejs-ai-platform#308)) ([6557767](googleapis/nodejs-ai-platform@6557767)) * add JOB_STATE_UPDATING to JobState in aiplatform v1beta1 job_state.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add LatestMonitoringPipelineMetadata to ModelDeploymentMonitoringJob in aiplatform v1beta1 model_deployment_monitoring_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add ListModelVersion, DeleteModelVersion, and MergeVersionAliases rpcs to aiplatform v1beta1 model_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add MfsMount in aiplatform v1beta1 machine_resources.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_id and parent_model to TrainingPipeline in aiplatform v1beta1 training_pipeline.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to DeployedModel in aiplatform v1beta1 endpoint.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to PredictResponse in aiplatform v1beta1 prediction_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to UploadModelRequest and UploadModelResponse in aiplatform v1beta1 model_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add nfs_mounts to WorkPoolSpec in aiplatform v1beta1 custom_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add PredictRequestResponseLoggingConfig to aiplatform v1beta1 endpoint.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add reserved_ip_ranges to CustomJobSpec in aiplatform v1 custom_job.proto ([#286](googleapis/nodejs-ai-platform#286)) ([863748a](googleapis/nodejs-ai-platform@863748a)) * add reserved_ip_ranges to CustomJobSpec in aiplatform v1beta1 custom_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add version_id to Model in aiplatform v1beta1 model.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * rename Similarity to Examples, and similarity to examples in ExplanationParameters in aiplatform v1beta1 explanation.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * **samples:** add create-featurestore samples ([#317](googleapis/nodejs-ai-platform#317)) ([5876d81](googleapis/nodejs-ai-platform@5876d81)) ### Bug Fixes * added retries to flaky test ([#299](googleapis/nodejs-ai-platform#299)) ([ffc9a3f](googleapis/nodejs-ai-platform@ffc9a3f)) ### Build System * update library to use Node 12 ([#304](googleapis/nodejs-ai-platform#304)) ([0679cda](googleapis/nodejs-ai-platform@0679cda)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/nodejs-ai-platform@v1.19.0...v2.0.0) (2022-06-23) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#304) ### Features * add ConvexAutomatedStoppingSpec to StudySpec in aiplatform v1beta1 study.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([#297](googleapis/nodejs-ai-platform#297)) ([1e6dcb6](googleapis/nodejs-ai-platform@1e6dcb6)) * add Examples to Explanation related messages in aiplatform v1beta1 explanation.proto ([#307](googleapis/nodejs-ai-platform#307)) ([c69ac2b](googleapis/nodejs-ai-platform@c69ac2b)) * add IAM policy to aiplatform_v1beta1.yaml ([#308](googleapis/nodejs-ai-platform#308)) ([6557767](googleapis/nodejs-ai-platform@6557767)) * add JOB_STATE_UPDATING to JobState in aiplatform v1beta1 job_state.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add LatestMonitoringPipelineMetadata to ModelDeploymentMonitoringJob in aiplatform v1beta1 model_deployment_monitoring_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add ListModelVersion, DeleteModelVersion, and MergeVersionAliases rpcs to aiplatform v1beta1 model_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add MfsMount in aiplatform v1beta1 machine_resources.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_id and parent_model to TrainingPipeline in aiplatform v1beta1 training_pipeline.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to DeployedModel in aiplatform v1beta1 endpoint.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to PredictResponse in aiplatform v1beta1 prediction_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to UploadModelRequest and UploadModelResponse in aiplatform v1beta1 model_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add nfs_mounts to WorkPoolSpec in aiplatform v1beta1 custom_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add PredictRequestResponseLoggingConfig to aiplatform v1beta1 endpoint.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add reserved_ip_ranges to CustomJobSpec in aiplatform v1 custom_job.proto ([#286](googleapis/nodejs-ai-platform#286)) ([863748a](googleapis/nodejs-ai-platform@863748a)) * add reserved_ip_ranges to CustomJobSpec in aiplatform v1beta1 custom_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add version_id to Model in aiplatform v1beta1 model.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * rename Similarity to Examples, and similarity to examples in ExplanationParameters in aiplatform v1beta1 explanation.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * **samples:** add create-featurestore samples ([#317](googleapis/nodejs-ai-platform#317)) ([5876d81](googleapis/nodejs-ai-platform@5876d81)) ### Bug Fixes * added retries to flaky test ([#299](googleapis/nodejs-ai-platform#299)) ([ffc9a3f](googleapis/nodejs-ai-platform@ffc9a3f)) ### Build System * update library to use Node 12 ([#304](googleapis/nodejs-ai-platform#304)) ([0679cda](googleapis/nodejs-ai-platform@0679cda)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

resolving b/131663796

jmdobry self-assigned this Jan 27, 2017

jmdobry force-pushed the kms branch 2 times, most recently from 0cc5d60 to fad68ab Compare January 27, 2017 19:28

jmdobry requested a review from ace-n January 27, 2017 20:04

jmdobry force-pushed the kms branch from fad68ab to 81cc1dd Compare January 27, 2017 22:12

Add KMS samples.

4036bcf

jmdobry force-pushed the kms branch from 81cc1dd to 4036bcf Compare January 27, 2017 22:17

ace-n approved these changes Jan 30, 2017

View reviewed changes

dpebot merged commit 27d9b85 into master Jan 30, 2017

dpebot deleted the kms branch January 30, 2017 19:03

snyk-bot mentioned this pull request Dec 24, 2020

[Snyk] Security upgrade @google-cloud/datastore from 2.0.0 to 3.1.0 leejh3224/nodejs-docs-samples#298

Open

ivanmkc mentioned this pull request Nov 3, 2022

Migrate code from googleapis/nodejs-datalabeling #2797

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency @google-cloud/storage to v3 (#304)

6c13e0f

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency @google-cloud/storage to v3 (#304)

6732b51

unforced mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-security-center #2867

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency @google-cloud/storage to v3 (#304)

9185920

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency @google-cloud/storage to v3 (#304)

a2ced16

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency @google-cloud/storage to v3 (#304)

a18e489

pattishin mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-ai-platform #2876

Merged

Shabirmean pushed a commit that referenced this pull request Feb 16, 2023

docs(samples): fix misleading comment (#304)

bfbafa5

resolving b/131663796

Shabirmean mentioned this pull request Feb 16, 2023

samples: migrate code from googleapis/nodejs-dlp #3035

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add KMS samples. #304

Add KMS samples. #304

Uh oh!

jmdobry commented Jan 27, 2017

Uh oh!

ace-n left a comment

Uh oh!

ace-n Jan 30, 2017

Uh oh!

jmdobry Jan 30, 2017

Uh oh!

ace-n Jan 30, 2017

Uh oh!

jmdobry Jan 30, 2017

Uh oh!

ace-n Jan 30, 2017

Uh oh!

jmdobry Jan 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add KMS samples. #304

Add KMS samples. #304

Uh oh!

Conversation

jmdobry commented Jan 27, 2017

Uh oh!

ace-n left a comment

Choose a reason for hiding this comment

Uh oh!

ace-n Jan 30, 2017

Choose a reason for hiding this comment

Uh oh!

jmdobry Jan 30, 2017

Choose a reason for hiding this comment

Uh oh!

ace-n Jan 30, 2017

Choose a reason for hiding this comment

Uh oh!

jmdobry Jan 30, 2017

Choose a reason for hiding this comment

Uh oh!

ace-n Jan 30, 2017

Choose a reason for hiding this comment

Uh oh!

jmdobry Jan 30, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants