Adds token refresh to HTTP example. #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 13 13
Lines 458 458
=======================================
Hits 445 445
Misses 13 13Continue to review full report at Codecov.
|
ace-n
approved these changes
Nov 3, 2017
| iatTime = parseInt(Date.now() / 1000); | ||
| console.log(`\tRefreshing token after ${secsFromIssue} seconds.`); | ||
|
|
||
| authToken = createJwt(argv.project_id, argv.private_key_file, |
Contributor
There was a problem hiding this comment.
Nit: this feels like it should be a one-liner.
You can get it under 80 characters using camel case (like the non-IoT samples) and shortening privateKeyFile to keyFile. (Worst case scenario, it's probably fine to go a little over 80 characters unless the linter says not to.)
ace-n
pushed a commit
that referenced
this pull request
Dec 4, 2017
* Adds token refresh to HTTP example. * Review feedback
NimJay
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
NimJay
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This was referenced Nov 14, 2022
kweinmeister
pushed a commit
that referenced
this pull request
Nov 18, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.