fix: return normalized paths from fixer on Windows #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay @jayu. |
|
Hi @HeroProtagonist , good point about tests. I will try to find some time at the weekend or next week. But if you like to do it earlier, feel free to merge it. |
|
@HeroProtagonist I'm sorry for that, but I'm a bit busy recently. |
|
@jayu thanks. this will be in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi, I just noticed that when eslint fixer is used on Windows, it returns incorrect paths with the wrong slash.
For example, it creates a fix with path
shared\componentsinsteadshared/components.This is due to Windows paths that obviously are defined with a backslash. I added normalize path to fix that problem