Skip to content

fix: BROS-253: Handle clicks outside the configuration modal #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 31, 2025

Conversation

Gondragos
Copy link
Collaborator

  • Add handling clicks outside the configuration modal for Video timeline configs
  • remove BEM styles

@Gondragos Gondragos requested a review from a team as a code owner July 28, 2025 15:03
Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 4a6c7a0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/688b1802ae32d30008a2a8e6

Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 4a6c7a0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/688b18029144dd00088f2ead
😎 Deploy Preview https://deploy-preview-8053--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 4a6c7a0
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/688b1802b1fce900082625c1

@github-actions github-actions bot added the fix label Jul 28, 2025
Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 4a6c7a0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/688b1802ad69cc0008d94a7a
😎 Deploy Preview https://deploy-preview-8053--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.89%. Comparing base (7269908) to head (4a6c7a0).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...omponents/Timeline/Controls/VideoConfigControl.tsx 65.38% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8053      +/-   ##
===========================================
- Coverage    70.36%   65.89%   -4.47%     
===========================================
  Files          719      505     -214     
  Lines        51031    33536   -17495     
  Branches      8622     8639      +17     
===========================================
- Hits         35906    22099   -13807     
+ Misses       15122    11434    -3688     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 59.47% <38.46%> (-0.02%) ⬇️
lsf-integration 55.65% <65.38%> (+0.01%) ⬆️
lsf-unit 9.45% <0.00%> (-0.01%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gondragos Gondragos changed the title fix: BROS-253: Handle clicks outside the configuration modal @Gondragos fix: BROS-253: Handle clicks outside the configuration modal Jul 28, 2025
@niklub
Copy link
Collaborator

niklub commented Jul 29, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 label_studio/users/tests/test_redis_activity.py

@niklub niklub enabled auto-merge (squash) July 29, 2025 21:54
@niklub niklub merged commit 75aec0e into develop Jul 31, 2025
62 of 66 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-BROS-253 branch July 31, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants