Skip to content

Conversation

@esnible
Copy link
Member

@esnible esnible commented Dec 18, 2024

A minor change to include the model name when reporting model failures.

If the failure is due to network connectivity, the output now includes that. Where before we logged

basic.pdl:4 - Error during model call: ConnectError('[Errno 61] Connection refused')

we now show

basic.pdl:4 - model 'ollama/granite-code:8b' encountered ConnectError('[Errno 61] Connection refused') trying to POST against http://localhost:11434/api/generate

@esnible esnible requested a review from vazirim December 18, 2024 19:48
Signed-off-by: Ed Snible <[email protected]>
Copy link
Member

@vazirim vazirim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vazirim vazirim merged commit 5898437 into IBM:main Dec 18, 2024
5 checks passed
@esnible esnible deleted the show-model-on-exception branch December 18, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants