-
Notifications
You must be signed in to change notification settings - Fork 47
Add comments to examples to make them more obvious #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,24 @@ | ||
| description: chatbot | ||
| text: | ||
| # Allow the user to type any question, implicitly adding the question to the context. | ||
| - read: | ||
| message: "What is your query?\n" | ||
| contribute: [context] | ||
| - repeat: | ||
| text: | ||
| # Send context to Granite model hosted at replicate.com | ||
| - model: replicate/ibm-granite/granite-3.0-8b-instruct | ||
| # Allow the user to type 'yes', 'no', or anything else, storing | ||
| # the input into a variable named `eval`. The input is also implicitly | ||
| # added to the context. | ||
| - read: | ||
| def: eval | ||
| message: "\nIs this a good answer[yes/no]?\n" | ||
| contribute: [context] | ||
| - "\n" | ||
| # If the user only typed "no", prompt the user for input to add to the context. | ||
| - if: ${ eval == 'no' } | ||
| then: | ||
| text: | ||
| - read: | ||
| message: "Why not?\n" | ||
| contribute: [] | ||
| # If the user typed only "yes", finish the `repeat` and end the program | ||
| until: ${ eval == 'yes'} | ||
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,25 @@ | ||
| description: Granite Multi-Round Chat | ||
| text: | ||
| - include: ./granite_defs.pdl | ||
| # Define the variable `defs` to contain the parsed multi-prompts.json | ||
| - read: ./multi-prompts.json | ||
| parser: json | ||
| def: prompts | ||
| # Type-check multi-prompts.json against a specification | ||
| spec: {prompts: [str]} | ||
| # Don't store these prompts in the PDL context | ||
| contribute: [] | ||
| # Pass each prompt to the model | ||
| - for: | ||
| prompt: ${ prompts.prompts } | ||
| repeat: | ||
| text: | ||
| # Output the question, and add it to the context | ||
| - | | ||
|
|
||
| ${ prompt } | ||
| # Use replicate.com to run the Granite model on the context, outputting the result | ||
| - model: replicate/ibm-granite/granite-3.0-8b-instruct | ||
| parameters: | ||
| # Use no LLM model creativity (0 is the default) | ||
| temperature: 0 | ||
| role: user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| description: Granite Single-Round Chat | ||
| text: | ||
| - include: ./granite_defs.pdl | ||
| # (Note that 'PROMPT' is undefined will happen if you don't invoke pdl with `-f prompt.json`) | ||
| - "${ PROMPT }\n" | ||
| - model: replicate/ibm-granite/granite-3.0-8b-instruct | ||
| parameters: | ||
| # Use no LLM model creativity (0 is the default) | ||
| temperature: 0 | ||
| role: user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@esnible I believe you still need
-f ./multi-prompts.json?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try it yourself? I did
pdl multi_round_chat.pdland from the home directorypdl examples/granite/multi_round_chat.pdl. Both worked.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, we have an include so
-fis not needed. Leftover from old ways of doing things.