Skip to content

Conversation

@ubyndr
Copy link
Collaborator

@ubyndr ubyndr commented Jun 7, 2023

resolves #3

Implemented basic functionality given in #3

TODO:

  • Add docstrings
  • Add poetry

Questions:

  • Are we going to use the schema/linkml library that we have talking about in this project? I think that is the case but I wanted to double check. If that is the case I take it we integrate it in later stages, am I right?
  • Do we plan to get anndata inputs from other sources? I've used local files only.

@ubyndr ubyndr requested a review from dosumis June 7, 2023 09:35
@dosumis
Copy link
Contributor

dosumis commented Jun 7, 2023

Are we going to use the schema/linkml library that we have talking about in this project? I think that is the case but I wanted to double check. If that is the case I take it we integrate it in later stages, am I right?

Yep. Just didn't add to MVP.

Do we plan to get anndata inputs from other sources? I've used local files only.

Local is fine for now. It may make sense in future to support loading from URL. Will be easy to add.

@dosumis
Copy link
Contributor

dosumis commented Jun 7, 2023

From eyeballing this - it looks fine. If you are happy that it works in local testing, I'm happy for you to merge once you've added some docstrings. Test cases can wait for a second PR.

@dosumis
Copy link
Contributor

dosumis commented Jun 7, 2023

Please also add STATUS: DRAFT/EXPERIMENTAL to the top of the README.md We can remove once more functionality& tests in place.

@ubyndr ubyndr marked this pull request as ready for review June 9, 2023 14:11
@ubyndr ubyndr merged commit 2b30ea2 into main Jun 9, 2023
@ubyndr ubyndr deleted the first-version branch June 9, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MVP / proof of concept release

3 participants