Aleksandr enivatov #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskonst
requested changes
Dec 16, 2019
added 3 commits
December 19, 2019 09:08
jskonst
requested changes
Dec 26, 2019
| } | ||
| else | ||
| { | ||
| throw new System.Exception(); |
There was a problem hiding this comment.
в смысле? нельзя пол кроме male установить?
CourseApp/Dog.cs
Outdated
| this.age++; | ||
| } | ||
|
|
||
| public override string Vote() |
| } | ||
| else | ||
| { | ||
| throw new System.Exception(); |
CourseApp/Tiger.cs
Outdated
|
|
||
| set | ||
| { | ||
| if (value >= 1 && value < 10) |
There was a problem hiding this comment.
Если у вас оба животных с одинаковым ограничением по возрасту -> надо в базовый класс это выносить, а лучше просто привести с другим возрастом
CourseApp/Tiger.cs
Outdated
|
|
||
| public override string ToString() | ||
| { | ||
| return $"Имя:{Name},Возраст:{Age},Пол:{Sex}"; |
There was a problem hiding this comment.
ToString тоже явный кандидат, чтобы или его переопределить и возвращать строки по другому или же вернуть это все в базовый класс
jskonst
requested changes
Dec 26, 2019
CourseApp/SuperAnimals.cs
Outdated
|
|
||
| public virtual string VirtualView() | ||
| { | ||
| return "Virtual Metod"; |
jskonst
requested changes
Dec 26, 2019
CourseApp/Dog.cs
Outdated
| public Dog(string name, int age, string sex) | ||
| : base(name, age, sex) | ||
| { | ||
| Name = name; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.