Skip to content

Implement _cat instead of cat #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Implement _cat instead of cat #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1ea66
Implement `_cat` instead of `cat`
lkdvos Feb 3, 2025
d1cf521
Bump v0.3.9
lkdvos Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "DerivableInterfaces"
uuid = "6c5e35bf-e59e-4898-b73c-732dcc4ba65f"
authors = ["ITensor developers <[email protected]> and contributors"]
version = "0.3.8"
version = "0.3.9"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
2 changes: 1 addition & 1 deletion src/abstractarrayinterface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@
return a_dest
end

@interface interface::AbstractArrayInterface function Base.cat(as::AbstractArray...; dims)
@interface interface::AbstractArrayInterface function Base._cat(dims, as::AbstractArray...)

Check warning on line 328 in src/abstractarrayinterface.jl

View check run for this annotation

Codecov / codecov/patch

src/abstractarrayinterface.jl#L328 

Added line #L328 was not covered by tests
a_dest = similar(Cat(as...; dims))
@interface interface cat!(a_dest, as...; dims)
return a_dest
Expand Down
2 changes: 1 addition & 1 deletion src/traits.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
Base.permutedims!(::Any, ::$type, ::Any)
Broadcast.BroadcastStyle(::Type{<:$type})
Base.copyto!(::$type, ::Broadcast.Broadcasted{Broadcast.DefaultArrayStyle{0}})
Base.cat(::$type...; kwargs...)
Base._cat(::Any, ::$type...)

Check warning on line 48 in src/traits.jl

View check run for this annotation

Codecov / codecov/patch

src/traits.jl#L48 

Added line #L48 was not covered by tests
ArrayLayouts.MemoryLayout(::Type{<:$type})
LinearAlgebra.mul!(::AbstractMatrix, ::$type, ::$type, ::Number, ::Number)
end
Expand Down