[GradedAxes] [BlockSparseArrays] Upgrade to BlockArrays.jl v1 #1495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary changes are:
BlockedOneToandGradedOneTo, i.e. hardcoded to start at 1 by the type system.GradedOneTonow properly has compile time element typeLabelledInteger, which is allowed as of BlockArrays.jl v1 sinceBlockedOneTo/BlockedUnitRangecan now have element types that are any subtype ofInteger, and not justIntas before v1.Currently,
GradedOneToandGradedUnitRangeare just type aliases forBlockArrays.BlockedOneToandBlockArrays.BlockedUnitRangewith labelled integer elements and labelled blocks. In the future we might consider defining them as separate types, as well as defining anAbstractGradedUnitRangesupertype for them. This PR definesAbstractGradedUnitRange, but it is just a type alias forBlockArrays.AbstractBlockedUnitRangewith labelled integer element type. Repurposing the existing types inBlockArraysseems to work well so far and works even better with BlockArrays v1.To-do:
BlockArrays.BlockedArrayobjects which drop the block labels, consider if this is the behavior we want. EDIT: I'll keep this behavior for now.