Skip to content

Conversation

@nilmerg
Copy link
Member

@nilmerg nilmerg commented Oct 8, 2025

This is an attempt to solve the problem of the now indicator to cut through a recipient's name. In dark mode this isn't too obvious, but in light mode the line makes characters hard to read if they overlap.

image image image image

@nilmerg nilmerg requested a review from flourish86 October 8, 2025 14:09
@nilmerg nilmerg self-assigned this Oct 8, 2025
@nilmerg nilmerg added the area/ui Affects the user interface label Oct 8, 2025
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 8, 2025
@flourish86
Copy link
Contributor

We figured, that if mixing the entry colors without transparency would prevent the hand from overlapping text.

CSS color-mix() looks promising for this and is supported widely enough.
https://caniuse.com/?search=color-mix

A text-shadow on the separate text node ("… to override rotations above") would prevent the handle from obscuring it.

To keep the now handle prominent enough the red line should overlay the gray background of the .new-rotation-content container.

All in all, I don't see a critical impact on legibility anyway. Since the handle is only 1px wide, the meaning could still be deduced from surrounding letters.

This is actually how reading works, e.g. shown by the missing letter effect

This is an attempt to solve the problem of the now indicator
to cut through a recipient's name. In dark mode this isn't
too obvious, but in light mode the line makes characters
hard to read if they overlap.
@nilmerg nilmerg force-pushed the fix/time-scale-now-line-obviousness branch from 505c1f1 to 47040b1 Compare November 5, 2025 16:02
@nilmerg nilmerg requested review from flourish86 and removed request for flourish86 November 5, 2025 16:02
@nilmerg
Copy link
Member Author

nilmerg commented Nov 5, 2025

Found another alternative. Now the line separating the result row is visible again as well, as it was covered prior.

Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@nilmerg nilmerg merged commit 4d15c8d into main Nov 7, 2025
10 checks passed
@nilmerg nilmerg deleted the fix/time-scale-now-line-obviousness branch November 7, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui Affects the user interface cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants