Fix backslashes in the url path causes an error

[yhabteab]

resolves #186

[LordHepipud]

Hello,

we will not do it this way. This will break the possibility to use web urls as it will enforce local paths instead of allowing local, web and network share paths.

Please use Test-Path to check if the path is a local path and use \ for splitting and otherewise /

[yhabteab]

I don't think that all local paths can be specified with backslash but also with a normal slash as @Nathaniel-Donahue described in the issue, so it would be better to just check if the url contains slash or backslash.

[LordHepipud]

It doesn't matter because the "fix" you provide will enforce a local path, because with your check testing for $CustomBinaryUrl will always result in $CustomBinaryUrl = $TRUE

It doesnt matter if you are using

C:\users\dummy\service.zip

or

https://example.com/binary.zip

Because you are always setting $CustomBinaryUrl = $TRUE by checking if $FrameworkServiceUrl is empty or not, you are not checking if it is a local path or a web path (both should work).

And therefor you are always enforcing this part:

if ($CustomBinaryUrl) {
       $ZipArchive = Join-Path -Path $TmpDirectory -ChildPath ($FrameworkServiceUrl.Split('\')[-1]);
}

With the latest update, you check in addition for bachslashes in the path with

if ($CustomBinaryUrl -and ($FrameworkServiceUrl.Contains('\'))) {

The proper solution would be this block:

if (Test-Path $FrameworkServiceUrl) {
    $ZipArchive = Join-Path -Path $TmpDirectory -ChildPath ($FrameworkServiceUrl.Replace('/', '\').Split('\')[-1]);
} else {
    $ZipArchive = Join-Path -Path $TmpDirectory -ChildPath ($FrameworkServiceUrl.Split('/')[-1]);
}

The rest of the updated code can be removed.

Because it doesn't matter on how you specify the local path:

icinga> Test-Path C:\Users\dummy\
True
icinga> Test-Path C:/Users/dummy/
True
icinga> Test-Path '\\network_fileshare\Icinga'
True
icinga> Test-Path '//network_fileshare/Icinga'
True
icinga> Test-Path 'www.icinga.com'
False

[LordHepipud]

LFTM