Fix: Threshold interval time conversion #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordHepipud
force-pushed
the
fix/threshold_interval_fails_on_minute_to_hour_conversion
branch
from
086a093 to
bfd0237
Compare
LordHepipud
changed the title
LordHepipud
deleted the
fix/threshold_interval_fails_on_minute_to_hour_conversion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
-ThresholdIntervalunit conversion, which causes an error if you want to convert60mor1h, as the used object is returning 0 for minutes in this matter, as the object itself moved to hours instead.We should use
TotalMinutesinstead ofMinuteson ourTimeSpanobject and round every single value returned to 0 digits.