Skip to content

Conversation

@yhabteab
Copy link
Member

@yhabteab yhabteab commented Sep 1, 2020

resolves #5

@yhabteab yhabteab added the bug Something isn't working label Sep 1, 2020
@yhabteab yhabteab requested a review from LordHepipud September 1, 2020 16:29
Copy link
Collaborator

@LordHepipud LordHepipud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kickstart was never intended to be running multiple times on a system while the Framework is already installed. There are actual functions already in place within the Framework to upgrade, downgrade it.

If we our intention is to fix this "issue" properly, we will have to either:

  • "Skip" the kickstart part within the Kickstart and using the Framework components already installed
  • Duplicate the entire code base for the Framework management into the Kickstart script (I really dont wanna do that))
  • Not support this at all

My suggestion would be to test if the Framework in Version 1.0.0 is already installed and in this case, skip the kickstart part and use the Framework functionallty directly.

This will allow users to manage every system with one entry point, the Kickstarter script, and still everything else is handled properly without duplicating too much code base.

@LordHepipud LordHepipud force-pushed the bugfix/framework-does-not-update-properly-#5 branch 3 times, most recently from f5ed57a to 63be511 Compare November 20, 2020 09:28
@LordHepipud LordHepipud force-pushed the bugfix/framework-does-not-update-properly-#5 branch from 63be511 to bac165b Compare November 20, 2020 09:30
@LordHepipud LordHepipud added this to the v1.2.0 milestone Nov 20, 2020
@LordHepipud LordHepipud merged commit 0005e96 into master Nov 20, 2020
@LordHepipud LordHepipud deleted the bugfix/framework-does-not-update-properly-#5 branch November 20, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kickstart script does not update the framework

3 participants