Form: Trigger ON_REQUEST only in case it's not been sent
#153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Literally no one ever used this event, since it served absolutely no purpose. Only a single control registers it on its own: ipl-web's `SortControl`, but guess what? The first check is whether the form has been sent or not and the listener only does something if not. And of course, it still needs to be triggered before assembly, as a listener will probably influence it.
nilmerg
force-pushed
the
make-on-request-useful
branch
from
da857ac to
0012156
Compare
nilmerg
added a commit
to Icinga/ipl-web
that referenced
this pull request
Aug 21, 2025
The event is not being triggered anymore if the form has been sent. Requires Icinga/ipl-html#153
nilmerg
added a commit
to Icinga/ipl-web
that referenced
this pull request
Aug 22, 2025
The event is not being triggered anymore if the form has been sent. Requires Icinga/ipl-html#153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literally no one ever used this event, since it served absolutely no purpose. Only a single control registers it on its own: ipl-web's
SortControl, but guess what? The first check is whether the form has been sent or not and the listener only does something if not.And of course, it still needs to be triggered before assembly, as a listener will probably influence it.