Skip to content

Conversation

@Ingrim4
Copy link
Member

@Ingrim4 Ingrim4 commented Oct 7, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Ingrim4 Ingrim4 marked this pull request as draft October 7, 2024 23:30
@NgLoader NgLoader requested a review from Copilot March 31, 2025 01:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements an experimental obfuscation engine with enhanced biome support. Key changes include:

  • Updates across multiple NmsManager implementations to correctly calculate the maximum number of bits needed for biome data.
  • Addition of a new maxBitsPerBiome field and supporting API methods in the abstract NMS manager and API interface.
  • A minor refactor in the world configuration interface, renaming shouldObfuscate to shouldProcessBlock.

Reviewed Changes

Copilot reviewed 51 out of 52 changed files in this pull request and generated no comments.

Show a summary per file
File Description
orebfuscator-plugin/src/main/java/net/imprex/orebfuscator/Orebfuscator.java Added a comment regarding GZIPOutputStream, potentially for future use.
Various orebfuscator-nms/v*/NmsManager.java Updated biome registry calls and adjusted constructor parameters for different Minecraft versions.
orebfuscator-nms-api/src/main/java/net/imprex/orebfuscator/nms/AbstractNmsManager.java Added support for maxBitsPerBiome along with a new getter method.
orebfuscator-nms-api/src/main/java/net/imprex/orebfuscator/OrebfuscatorNms.java Added a new getter for maxBitsPerBiome and updated the version string logic.
orebfuscator-common/src/main/java/net/imprex/orebfuscator/config/WorldConfigBundle.java Renamed shouldObfuscate to shouldProcessBlock to better represent its purpose.
Files not reviewed (1)
  • orebfuscator-plugin/pom.xml: Language not supported
Comments suppressed due to low confidence (1)

orebfuscator-nms/orebfuscator-nms-api/src/main/java/net/imprex/orebfuscator/OrebfuscatorNms.java:29

  • Clarify the rationale for excluding Paper servers from appending '_mojang' to the version string. If this exclusion is intentional, a brief comment explaining the reason would be helpful.
if (ServerVersion.isMojangMapped() && !ServerVersion.isPaper()) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants