Skip to content

fixed goarch for cli #4165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CodeStaple
Copy link

@CodeStaple CodeStaple commented Jul 16, 2025

Description 📣

CLI is not building arm arch in gorelease. After investigating we seem to be doing 2 docker image builds for CLI with amd where it is obvious it should be only 1 and the other is arm.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

GOOS=linux GOARCH=arm64 CGO_ENABLED=0 go build -ldflags="-s -w" -o infisical .
root@ankra-io:~# ./infisical-arm64
Infisical is a simple, end-to-end encrypted service that enables teams to sync and manage their environment variables across their development life cycle.

Usage:
  infisical [command]

Available Commands:
  agent           Used to launch a client daemon that streamlines authentication and secret retrieval processes in various environments
  bootstrap       Used to bootstrap your Infisical instance
  dynamic-secrets Used to list dynamic secrets
  export          Used to export environment variables to a file
  gateway         Run the Infisical gateway or manage its systemd service
  help            Help about any command
  init            Used to connect your local project with Infisical project
  kmip            Used to manage KMIP servers
  login           Login into your Infisical account
  reset           Used to delete all Infisical related data on your machine
  run             Used to inject environments variables into your application process
  scan            Scan for leaked secrets in git history, directories, and files
  secrets         Used to create, read update and delete secrets
  service-token   Manage service tokens
  ssh             Used to issue SSH credentials
  token           Manage your access tokens
  user            Used to manage local user credentials
  vault           Used to manage where your Infisical login token is saved on your machine

Flags:
      --domain string      Point the CLI to your own backend [can also set via environment variable name: INFISICAL_API_URL] (default "https://app.infisical.com/api")
  -h, --help               help for infisical
  -l, --log-level string   log level (trace, debug, info, warn, error, fatal) (default "info")
      --silent             Disable output of tip/info messages. Useful when running in scripts or CI/CD pipelines.
      --telemetry          Infisical collects non-sensitive telemetry data to enhance features and improve user experience. Participation is voluntary (default true)
  -v, --version            version for infisical

Use "infisical [command] --help" for more information about a command.

@maidul98
Copy link
Collaborator

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a critical bug in the GoReleaser configuration where Docker images for the CLI were not being properly built for ARM architecture. The original configuration had two Docker builds both targeting amd64, which was redundant and failed to provide ARM support. The fix changes the second Docker build configuration to use arm64 architecture instead of duplicating amd64.

This change is particularly important because:

  1. It enables proper multi-architecture support for the CLI Docker images
  2. It aligns with the Docker manifest configuration that expects both amd64 and arm64 variants
  3. It ensures ARM-based systems (like Apple M1/M2 machines or ARM-based servers) can run the CLI efficiently

Confidence score: 5/5

  1. This PR is extremely safe to merge as it fixes an obvious configuration error
  2. The change is straightforward, only modifying the architecture target from amd64 to arm64 in the second Docker build configuration
  3. No files need special attention as the change is isolated to the GoReleaser configuration and the impact is clear

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants