Skip to content
This repository was archived by the owner on Nov 18, 2021. It is now read-only.

Conversation

@jnohlgard
Copy link
Contributor

It is better to let the user manage the dependencies, especially since different deployment tasks may depend on different build tasks.
This PR changes the file property to use @InputFile annotations to allow Gradle to discover the build steps automatically instead of always relying on the build task to produce the archive to deploy.
Additionally, in order to allow the names for the archive, runtime and deployment to be lazily resolved, the properties are changed from plain String into Gradle Property<String> and RegularFileProperty

The lazy configuration allows us to avoid adding an afterEvaluate block in build.gradle to set the file name for a project I have at work where the file name is configured from a number of other properties, (git commit id, gradle.properties, and some other things).

See also: https://docs.gradle.org/current/userguide/lazy_configuration.html

@Ingwersaft
Copy link
Owner

Hey, thanks for your contribution!
I'll try to review it this week - if time allows :)

@Ingwersaft
Copy link
Owner

This breaks the API, so the documentation and the integration will be wrong after your changes. Please adapt the documentation to the changed API and also the integration build script as well, thanks!

@jnohlgard
Copy link
Contributor Author

@Ingwersaft Updated integration build script and README.md

@Ingwersaft Ingwersaft merged commit b3868e9 into Ingwersaft:master Jan 21, 2020
@Ingwersaft
Copy link
Owner

Sorry for the late response! Thanks for updating, looks good to me! Will release it right after the CI job succeeds 👍

@jnohlgard jnohlgard deleted the dependson-not-build branch January 22, 2020 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants