Skip to content

Scikit build core #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 8, 2024
Merged

Scikit build core #267

merged 15 commits into from
Apr 8, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Mar 28, 2024 •
edited
Loading

Closes #217

@thewtex
Copy link
Member Author

thewtex commented Mar 28, 2024

@jcfr @henryiii

❯ for ff in dist/*.whl; do abi3audit --assume-minimum-abi3 3.11 $ff; done
[10:12:35] 🤷 nothing auditable found in dist/itk-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl    [10:12:39] 💁 itk_core-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 34 extensions scanned; 0 ABI 
           version mismatches and 0 ABI violations found                                         
[10:12:42] 💁 itk_filtering-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 22 extensions scanned; 0
           ABI version mismatches and 0 ABI violations found                                     
[10:12:45] 💁 itk_io-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 17 extensions scanned; 0 ABI   
           version mismatches and 0 ABI violations found                                         
[10:12:48] 💁 itk_numerics-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 13 extensions scanned; 0 
           ABI version mismatches and 0 ABI violations found                                     
[10:12:49] 💁 itk_registration-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 5 extensions scanned;
           0 ABI version mismatches and 0 ABI violations found                                   
[10:12:50] 💁 itk_segmentation-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 5 extensions scanned;
           0 ABI version mismatches and 0 ABI violations found

👨‍🎤 !

jcfr
jcfr reviewed Mar 28, 2024
View reviewed changes
henryiii
henryiii reviewed Mar 28, 2024
View reviewed changes
@thewtex thewtex force-pushed the scikit-build-core branch from f48677a to 2d7ece0 Compare March 29, 2024 15:44
@thewtex
Copy link
Member Author

thewtex commented Mar 29, 2024

@jcfr @henryiii thanks for the review! Suggestions integrated with local changes.

I tested against the ITK Sphinx Examples

  • 3.9 wheels against a 3.9 environment -- all tests pass 💚
  • 3.11 wheels against a 3.11 environment -- all tests pass 💚 🎇
  • 3.11 wheels against a 3.12 environment -- all tests pass 💚 🎸 ❇️

@thewtex thewtex force-pushed the scikit-build-core branch from 2d7ece0 to 0d7a5e3 Compare March 29, 2024 21:03
@thewtex thewtex force-pushed the scikit-build-core branch from 0d7a5e3 to 8cf816b Compare April 1, 2024 14:33
@thewtex
Copy link
Member Author

thewtex commented Apr 3, 2024

Voila, Windows:

MINGW64 /c/P/IPP (scikit-build-core)
$ ./venv-311-x64/Scripts/abi3audit.exe --assume-minimum-abi3 3.11 dist/*.whl
[14:38:08] 💁 itk_filtering-5.4rc3-cp311-abi3-win_amd64.whl: 22 extensions scanned; 0 ABI version mismatches and 0 ABI
           violations found
[14:39:13] 💁 itk_core-5.4rc3-cp311-abi3-win_amd64.whl: 34 extensions scanned; 0 ABI version mismatches and 0 ABI violations
           found
[14:40:19] 💁 itk_numerics-5.4rc3-cp311-abi3-win_amd64.whl: 13 extensions scanned; 0 ABI version mismatches and 0 ABI
           violations found
           🤷 nothing auditable found in dist/itk-5.4rc3-cp311-abi3-win_amd64.whl
[14:40:32] 💁 itk_segmentation-5.4rc3-cp311-abi3-win_amd64.whl: 5 extensions scanned; 0 ABI version mismatches and 0 ABI
           violations found
[14:40:42] 💁 itk_io-5.4rc3-cp311-abi3-win_amd64.whl: 17 extensions scanned; 0 ABI version mismatches and 0 ABI violations
           found
[14:41:03] 💁 itk_registration-5.4rc3-cp311-abi3-win_amd64.whl: 5 extensions scanned; 0 ABI version mismatches and 0 ABI
           violations found

@thewtex
Copy link
Member Author

thewtex commented Apr 4, 2024

And mac:

❯ abi3audit --assume-minimum-abi3 3.11 dist/*abi3*.whl
[14:50:19] 💁 itk_registration-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 5    
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:21] 💁 itk_core-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 34 extensions
           scanned; 0 ABI version mismatches and 0 ABI violations found      
[14:50:22] 💁 itk_numerics-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 13       
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
           💁 itk_segmentation-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 5    
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:24] 💁 itk_filtering-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 22      
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:25] 💁 itk_registration-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 5    
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
           🤷 nothing auditable found in                                     
           dist/itk-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl                  
[14:50:26] 💁 itk_io-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 17 extensions  
           scanned; 0 ABI version mismatches and 0 ABI violations found      
[14:50:29] 💁 itk_core-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 34 extensions
           scanned; 0 ABI version mismatches and 0 ABI violations found      
           🤷 nothing auditable found in                                     
           dist/itk-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl                  
           💁 itk_segmentation-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 5    
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:30] 💁 itk_numerics-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 13       
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:32] 💁 itk_io-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 17 extensions  
           scanned; 0 ABI version mismatches and 0 ABI violations found      
[14:50:33] 💁 itk_filtering-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 22      
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found

@thewtex thewtex force-pushed the scikit-build-core branch from 0dd4467 to 7419e1d Compare April 4, 2024 19:11
@thewtex thewtex force-pushed the scikit-build-core branch from 7419e1d to 09292e4 Compare April 5, 2024 20:00
thewtex added 2 commits April 6, 2024 20:59
@thewtex
BUG: Use build instead of pip for builds
1dc4ecb 
pip wheel --config-settings flag is not available in the pip available with Python 3.8,
3.9 on macOS.
@thewtex
ENH: macOS remote module scikit-build-core support
583af7b 
In ITK 5.4 RC3, we provide macOS swig binaries. The path in the
distribution has changed and is more complex -- just fetch the binaries
at build time.

Continue to support setup.py from scikit-build classic, but use
scikit-build-core with the Stable ABI when setup.py has been migrated to
pyproject.toml.
@thewtex thewtex force-pushed the scikit-build-core branch from 6b427b6 to 583af7b Compare April 7, 2024 18:44
thewtex added 2 commits April 7, 2024 16:14
@thewtex
ENH: linux amd64 scikit-build-core support
a7d75b0 
The requirements-dev.txt file was missing from the tarball, which was an
existing bug.
@thewtex
ENH: Install ninja for linux aarch64 remote module builds
c625367
@thewtex thewtex marked this pull request as ready for review April 8, 2024 11:57
@thewtex thewtex merged commit b8b9971 into InsightSoftwareConsortium:master Apr 8, 2024
@thewtex thewtex deleted the scikit-build-core branch April 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfr jcfr jcfr left review comments

+1 more reviewer

@henryiii henryiii henryiii left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to scikit-build-core

3 participants

@thewtex @jcfr @henryiii