ENH: Update for ITKPythonPackage script updates #15
Conversation
Changes:
- Expose ITKPythonPackage organization and tag parameters to facilitate
1) testing ITKPythonPackage script updates from user forks and 2)
applying ITKPythonPackage script patches introduced after packaging
in ITKPythonBuilds archives
- Update `MANYLINUX_VERSION` parameter for Linux wheel build scripts
| fi | ||
| for tarball in "-manylinux_2_28" "-manylinux2014"; do | ||
| for manylinux_version in "_2_28" "2014"; do |
There was a problem hiding this comment.
Why do we repeat the builds twice?
There was a problem hiding this comment.
I'm not sure I understand? Here we build once for -manylinux_2_28 and then once for -manylinux2014.
There was a problem hiding this comment.
Yes, but why do we build for two Linux versions?
There was a problem hiding this comment.
I believe these are for compatibility with different toolchains, i.e. -manylinux2014 for older platforms and -manylinux_2_28 for newer platforms. See the compliance chart in the manylinux README: https://github.com/pypa/manylinux#manylinux
@thewtex may be able to provide more detail on the motivation for -manylinux2014 wheels. I will also update this list in the near future for a third Linux build targeting ARM architectures to build on @thewtex 's recent work in ITKPythonPackage.
|
Moving forward with merging, only change from review was updating ITKPythonPackage hash to reference merge commit in |
2 participants
Changes:
MANYLINUX_VERSIONparameter for Linux wheel build scriptsDepends on InsightSoftwareConsortium/ITKPythonPackage#233