ENH: Use Windows build script to generate Python wheels #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbirdso
commented
Dec 13, 2022
dzenanz
approved these changes
Dec 13, 2022
Replaces inline Command Prompt build setup procedures in favor of ITKPythonPackage PowerShell script. Centralizing the Windows Python build procedures in an ITKPythonPackage script will improve ease of maintenance and allow the process to be more easily replicated on a local system for testing.
tbirdso
force-pushed
the
use-windows-download-script
branch
from
56b882a to
6ad6d59
Compare
|
Updated EDIT: Testing at https://github.com/tbirdso/ITKSplitComponents/actions/runs/3686731306/jobs/6239370043 EDIT2: Windows Python packages are passing 🟢 |
tbirdso
force-pushed
the
use-windows-download-script
branch
from
baf56f9 to
56b882a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces inline Command Prompt build setup procedures in favor of ITKPythonPackage PowerShell script.
Centralizing the Windows Python build procedures in an ITKPythonPackage script will improve ease of maintenance and allow the process to be more easily replicated on a local system for testing.
Testing in ITKSplitComponents with accompanying ITKPythonPackage changes has succeeded: https://github.com/tbirdso/ITKSplitComponents/actions/runs/3685964482/jobs/6237566090
Depends on changes in ITKPythonPackage: InsightSoftwareConsortium/ITKPythonPackage#242