STYLE: CoordRepType -> CoordinateType code readability #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
2a47f47 to
6caeb96
Compare
dzenanz
approved these changes
Jan 26, 2025
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
6caeb96 to
5faa768
Compare
github-actions
bot
added
area:Filtering
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
8b25658 to
34bc46c
Compare
github-actions
bot
added
the
type:Infrastructure
hjmjohnson
force-pushed
the
use-CoordinateType
branch
2 times, most recently
from
a1c5e7f to
5faa768
Compare
github-actions
bot
added
type:Infrastructure
hjmjohnson
force-pushed
the
use-CoordinateType
branch
7 times, most recently
from
e7bdbf0 to
f2e9abc
Compare
github-actions
bot
removed
area:Core
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
d32680f to
5708f5b
Compare
|
@dzenanz @thewtex I need to stop working on making these CI environments working. It is sooooo complicated. It depends on files from many different repos and branch are needed ITK/dashboard branch cmake files that write temporary files that get files from other repos branches. I can't track the trail of complex dependancies, and I can not get the failures replicated on my local computers. |
|
I might get around to taking a look at this today. |
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
d15f8e6 to
5708f5b
Compare
|
@hjmjohnson yes, I am working on replacing the system. |
clang-format version 8.0.0 binaries are no longer necessary. There are several ways (including pip install) to get the clang-format version 19 that are consistent with recent ITK style.
Made it clearer that `QuadEdgeMeshBoundaryEdgesMeshFunction` just use a _raw_ pointer (not a smart pointer) to the edge list.
For the sake of code readability, a new 'CoordinateType' alias is added for each nested 'CoordRepType' alias. The old 'CoordRepType' aliases will still be available with ITK 6.0, but it is recommended to use 'CoordinateType' instead. The 'CoordRepType' aliases will be removed when 'ITK_FUTURE_LEGACY_REMOVE' is enabled. Similarly, 'InputCoordinateType', 'OutputCoordinateType', and 'ImagePointCoordinateType' replace 'InputCoordRepType', 'OutputCoordRepType', and 'ImagePointCoordRepType', respectively.
The convention of only specifying the MAJOR version is the indicator that the latest version in that series should be used. By not specifying the MINOR and PATCH, the exact versions is not pinned, but the latest in that series is chosen. (i.e. the v5 tag is updated every time a new MINOR or PATCH tag is generated). This allows benefiting from minor patch fixes without needing to update workflows.
Set version requirements for CMake and Python to match ITK 5.4.2
build against itk 5.4.2 or greater versions.
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
facd719 to
b39e595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of code readability, a new 'CoordinateType' alias is added for
each nested 'CoordRepType' alias. The old 'CoordRepType' aliases will still be
available with ITK 6.0, but it is recommended to use 'CoordinateType' instead.
The 'CoordRepType' aliases will be removed when 'ITK_FUTURE_LEGACY_REMOVE' is
enabled. Similarly, 'InputCoordinateType', 'OutputCoordinateType', and
'ImagePointCoordinateType' replace 'InputCoordRepType', 'OutputCoordRepType',
and 'ImagePointCoordRepType', respectively.