Skip to content

Example options #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2019
Merged

Example options #12

merged 2 commits into from
May 8, 2019

Conversation

@thewtex
Copy link
Member

@thewtex thewtex commented Apr 25, 2019

No description provided.

thewtex added 2 commits April 25, 2019 09:44
@thewtex
ENH: Get example ImageType from input image
ccf40d2 
Since the TV filter internally uses `double` pixel type, read in as
double and cast to the native type after processing.
@thewtex
ENH: Weight and maxIterations defaults in the example
41bee6d
@thewtex thewtex requested a review from phcerdan April 25, 2019 13:51
phcerdan
phcerdan reviewed May 3, 2019
View reviewed changes
Copy link
Collaborator

@phcerdan phcerdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, does it work with non-float/non-double images?
Not sure if there is any precondition about pixel type (or if there is a cast to float/double) in the class.

@thewtex
Copy link
Member Author

thewtex commented May 8, 2019

Yes, it works with all input image component pixel types.

@phcerdan phcerdan merged commit 5b562c9 into InsightSoftwareConsortium:master May 8, 2019
@thewtex thewtex deleted the example-options branch May 8, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phcerdan phcerdan phcerdan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thewtex @phcerdan