LSM trees initial integration #1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
commented
Jul 16, 2025
ouroboros-consensus-cardano/src/byron/Ouroboros/Consensus/Byron/ByronHFC.hs
Outdated
Show resolved
Hide resolved
...oros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Ledger.hs
Outdated
Show resolved
Hide resolved
...oros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Ledger.hs
Outdated
Show resolved
Hide resolved
...oros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Ledger.hs
Outdated
Show resolved
Hide resolved
...oros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Ledger.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/unstable-mock-block/Ouroboros/Consensus/Mock/Ledger/Block.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test/storage-test/Test/Ouroboros/Storage/ChainDB/FollowerPromptness.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test/storage-test/Test/Ouroboros/Storage/LedgerDB/V1/BackingStore.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test/storage-test/Test/Ouroboros/Storage/LedgerDB/V1/BackingStore.hs
Outdated
Show resolved
Hide resolved
jasagredo
changed the base branch from
main
to
coot/cardano-diffusion-integration
jasagredo
force-pushed
the
js/lsm1
branch
6 times, most recently
from
4eaa608 to
97d30af
Compare
geo2a
reviewed
Jul 17, 2025
jasagredo
requested review from
amesgen,
dnadales,
fraser-iohk and
nfrisby
as code owners
coot
force-pushed
the
coot/cardano-diffusion-integration
branch
from
37619a9 to
d62dc42
Compare
jasagredo
changed the base branch from
coot/cardano-diffusion-integration
to
main
jasagredo
force-pushed
the
js/lsm1
branch
2 times, most recently
from
dad593f to
26e6455
Compare
geo2a
reviewed
Jul 21, 2025
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/Snapshots.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/Snapshots.hs
Outdated
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V1/Snapshots.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LSM.hs
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/lsm1
branch
2 times, most recently
from
12a1acb to
4119afa
Compare
amesgen
reviewed
Sep 4, 2025
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LSM.hs
Outdated
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/lsm1
branch
3 times, most recently
from
4ccdfb9 to
30c149e
Compare
amesgen
reviewed
Sep 29, 2025
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/IndexedMemPack.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/IndexedMemPack.hs
Outdated
Show resolved
Hide resolved
dnadales
approved these changes
Sep 29, 2025
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Args.hs
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LedgerSeq.hs
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LedgerSeq.hs
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LedgerSeq.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LSM.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LSM.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LSM.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LSM.hs
Outdated
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/lsm1
branch
2 times, most recently
from
81c8c09 to
074e656
Compare
An extra version of `text` is in the plan.json as a dependency of a `custom-setup` or `build-tool-depends`. Using `exactDeps = true` prevent those from getting into the plan.json. Co-authored-by: Hamish Mackenzie <[email protected]>
bladyjoker
reviewed
Oct 7, 2025
Comment on lines
+115
to
+120
| error $ | ||
| unlines | ||
| [ "There was an error deserializing a TxOut from the LSM backend." | ||
| , "This will likely result in a restart-crash loop." | ||
| , "The error: " <> show err | ||
| ] |
There was a problem hiding this comment.
Not thrilled to see error here. Still looking to understand where the fromTxoutBytes is used from perhaps it's possible to gracefully handle the error condition without calling error?
There was a problem hiding this comment.
Looked at from fromTxInBytes and fromTxOutBytes and error calls therein. Couple of questions:
- Should we introduce module level
Errortype and handle such conditions gracefully?
data Error = TxOutDecodingError SomeError | TxInDecodingError SomeError | InternalError Text
Even though we're calling from functions in IOLike m, it would be very useful to have structured error types such that we can eventually also provide machine readable errors in agreed upon format etc.
- What's our take on
errorgenerally?
There was a problem hiding this comment.
In general we don't like error but for unrecoverable situations like this one it is somewhat OK. We cannot handle such an error in any meaningful way so we just have to crash. Having a module level Error type would help us with readability of the error though...
bladyjoker
reviewed
Oct 7, 2025
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LSM.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/LSM.hs
Show resolved
Hide resolved
bladyjoker
approved these changes
Oct 9, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Consensus Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate the LSM trees as a new backend for the LedgerDB.