SCP-2693: New PIR.LetFloat #3823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezirg
force-pushed
the
bezirg/newletfloat
branch
4 times, most recently
from
596578f to
fd416eb
Compare
Contributor
|
(Requesting a review from Jakub, fo when Nikos thinks this is ready to look at!) |
jakzale
reviewed
Sep 3, 2021
jakzale
reviewed
Sep 3, 2021
bezirg
force-pushed
the
bezirg/newletfloat
branch
from
0fa32ac to
7bef1a1
Compare
bezirg
force-pushed
the
bezirg/newletfloat
branch
3 times, most recently
from
fc86b27 to
1f6e84a
Compare
11 tasks
bezirg
force-pushed
the
bezirg/newletfloat
branch
from
14d3a07 to
cd108d4
Compare
bezirg
force-pushed
the
bezirg/newletfloat
branch
from
cd108d4 to
52c8fb8
Compare
bezirg
force-pushed
the
bezirg/newletfloat
branch
from
52c8fb8 to
8aab0d4
Compare
jakzale
approved these changes
Sep 9, 2021
Contributor
jakzale
left a comment
jakzale
left a comment
There was a problem hiding this comment.
I have added some minor comments and possible improvements to how Pos is handled.
Looks good. My only concern is that after reading the file multiple times I still do not completely grok how the floating works...
michaelpj
reviewed
Sep 12, 2021
Contributor
michaelpj
left a comment
michaelpj
left a comment
There was a problem hiding this comment.
Still reviewing the floating back. Along the way, I did the writer transformation because I wanted to check that it would actually work 😅 which it does. I pushed the commits to this branch but. Feel free to take it or do something else.
| makeNewLet :: NE.NonEmpty (LetNaked tyname name uni fun a) -> Term tyname name uni fun a -> Term tyname name uni fun a | ||
| makeNewLet floatableNaked = | ||
| -- arbitrary: use the annotation of the first let of the floated lets as the annotation of the new let | ||
| -- TODO: use some semigroup annotation-joining instead |
michaelpj
reviewed
Sep 12, 2021
michaelpj
reviewed
Sep 12, 2021
Contributor
|
Okay, basically LGTM! |
michaelpj
reviewed
Sep 14, 2021
bezirg
force-pushed
the
bezirg/newletfloat
branch
from
a29a313 to
9970a8d
Compare
michaelpj
force-pushed
the
bezirg/newletfloat
branch
from
7b3533e to
cf324ee
Compare
bezirg
force-pushed
the
bezirg/newletfloat
branch
from
2667c03 to
d8bcb64
Compare
Forgot to recurse the removeLets inside the rhs bindings WIP: separated depth and scope reader WIP: fixed remaining bugs NewLetFloat: fixed accumulating letholes, fixed depth-calc of mark Fixed floatBack to recurse inside the floated-lets rhs'es Don't store the Recursivity for LetHoles NewLetFloat: when calculating freevars look into bindings' types Clean up, refactor More refactoring Changed from unmovable to floatable Formatting Rewrite removeLets to use Writer Rewrite mark to use Writer Make MarkCtx a datatype Make Pos a datatype PR adressing semigroup annotation joining update nix+fixstylishhaskell
bezirg
force-pushed
the
bezirg/newletfloat
branch
from
d8bcb64 to
66c4552
Compare
Contributor
|
Succeeded on all the linux jobs, let's just merge this. |
awkure
pushed a commit
to mlabs-haskell/plutus
that referenced
this pull request
Sep 15, 2021
Forgot to recurse the removeLets inside the rhs bindings WIP: separated depth and scope reader WIP: fixed remaining bugs NewLetFloat: fixed accumulating letholes, fixed depth-calc of mark Fixed floatBack to recurse inside the floated-lets rhs'es Don't store the Recursivity for LetHoles NewLetFloat: when calculating freevars look into bindings' types Clean up, refactor More refactoring Changed from unmovable to floatable Formatting Rewrite removeLets to use Writer Rewrite mark to use Writer Make MarkCtx a datatype Make Pos a datatype PR adressing semigroup annotation joining update nix+fixstylishhaskell Co-authored-by: Nikolaos Bezirgiannis <[email protected]>
jonesnoaht
pushed a commit
to jonesnoaht/plutus
that referenced
this pull request
Oct 8, 2021
Forgot to recurse the removeLets inside the rhs bindings WIP: separated depth and scope reader WIP: fixed remaining bugs NewLetFloat: fixed accumulating letholes, fixed depth-calc of mark Fixed floatBack to recurse inside the floated-lets rhs'es Don't store the Recursivity for LetHoles NewLetFloat: when calculating freevars look into bindings' types Clean up, refactor More refactoring Changed from unmovable to floatable Formatting Rewrite removeLets to use Writer Rewrite mark to use Writer Make MarkCtx a datatype Make Pos a datatype PR adressing semigroup annotation joining update nix+fixstylishhaskell Co-authored-by: Nikolaos Bezirgiannis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new PIR.letfloat pass that floats maximally outwards (a.k.a. full laziness).
The algorithm is influenced by "Let-floating: moving bindings to give faster programs",
where the authors also make use of the free term&type variables of to-float lets to calculate their maximum floating position.
Unlike their approach, we apply this floating transformation in a global fashion ; unlike their source language (ghc-core), we have to make sure not to float any effectful lets.
Pre-submit checklist: