Skip to content

Conversation

@Isotr0py
Copy link
Owner

Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py requested a review from Copilot September 28, 2025 08:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up dead code from a legacy MMQ (mul_mat_q) implementation. The changes involve removing unused function definitions, macro definitions, and associated tile allocation/loading functions that are no longer needed after the implementation was refactored in PR #5.

Key changes:

  • Removed numerous MMQ-related macro definitions (VDR_*_MMQ)
  • Moved core MMQ implementation functions to a dedicated header file
  • Eliminated dead template functions for memory allocation and tile loading

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
hf-kernels/ggml-kernels/ggml/vecdotq.cuh Removed legacy MMQ macro definitions and dead implementation functions while preserving MMVQ functionality
hf-kernels/ggml-kernels/ggml/mmq.cuh Added consolidated MMQ implementation functions and macro definitions to new dedicated header

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Isotr0py Isotr0py merged commit 7d62e28 into main Sep 28, 2025
@Isotr0py Isotr0py deleted the mmq-cleanup branch September 28, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant