Improve person names checker (#2876)

tobiasdiez · web-flow · commit 5a36a2a4057f · 2017-06-07T20:19:32.000+02:00
* Improve person name checker: also test that names are in BibTeX format

* Update localization

* Fix el language file

* Fix tests

* Fix tr language file
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - All authors and editors are separated using semicolons when exporting to csv. [#2762](https://github.com/JabRef/jabref/issues/2762)
 - Improved wording of "Show recommendations: into "Show 'Related Articles' tab" in the preferences
 - We added integration of the Library of Congress catalog as a fetcher based on the [LCCN identifier](https://en.wikipedia.org/wiki/Library_of_Congress_Control_Number). [Feature request 636 in the forum](http://discourse.jabref.org/t/loc-marc-mods-connection/636)
+- The integrity check for person names now also tests that the names are specified in one of the standard BibTeX formats.
 
 ### Fixed
 - We fixed the adding of a new entry from DOI which led to a connection error. The DOI resolution now uses HTTPS to protect the user's privacy.[#2879](https://github.com/JabRef/jabref/issues/2897)
diff --git a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java
@@ -4,6 +4,7 @@
 import java.util.Optional;
 
 import org.jabref.logic.l10n.Localization;
+import org.jabref.model.entry.AuthorList;
 
 public class PersonNamesChecker implements ValueChecker {
 
@@ -15,6 +16,16 @@ public Optional<String> checkValue(String value) {
         } else if (valueTrimmedAndLowerCase.endsWith(" and") || valueTrimmedAndLowerCase.endsWith(",")) {
             return Optional.of(Localization.lang("should end with a name"));
         }
+
+        // Check that the value is in one of the two standard BibTeX formats:
+        //  Last, First and ...
+        //  First Last and ...
+        AuthorList authorList = AuthorList.parse(value);
+        if (!authorList.getAsLastFirstNamesWithAnd(false).equals(value)
+                && !authorList.getAsFirstLastNamesWithAnd().equals(value)) {
+            return Optional.of(Localization.lang("Names are not in the standard BibTeX format."));
+        }
+
         return Optional.empty();
     }
 }
diff --git a/src/main/resources/l10n/JabRef_da.properties b/src/main/resources/l10n/JabRef_da.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_de.properties b/src/main/resources/l10n/JabRef_de.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=Teile_anonyme_Statistiken
 Telemetry\:_Help_make_JabRef_better=Telemetrie\:_Helfen_Sie,_JabRef_zu_verbessern
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=Zur_Verbesserung_der_Benutzererfahrung_würden_wir_gerne_anonyme_Statistiken_über_die_Features_sammeln,_die_Sie_benutzen._Wir_zeichnen_nur_auf,_welche_Features_Sie_nutzen_und_wie_oft_Sie_diese_benutzen._Es_werden_keinerlei_persönliche_Informationen_über_Sie_oder_den_Inhalt_Ihrer_Bibliografieeinträge_gesammelt._Die_einmal_erlaubte_Datenaufzeichnnung_kann_jederzeit_unter_Optionen->Einstellungen->Allgemein_deaktiviert werden.
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=Share_anonymous_statistics
 Telemetry\:_Help_make_JabRef_better=Telemetry\:_Help_make_JabRef_better
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?
+Names_are_not_in_the_standard_BibTeX_format.=Names_are_not_in_the_standard_BibTeX_format.
diff --git a/src/main/resources/l10n/JabRef_es.properties b/src/main/resources/l10n/JabRef_es.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=Compartir_estadísticas_anónimas
 Telemetry\:_Help_make_JabRef_better=Telemetría:\_Ayude_a_mejorar_JabRef
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=Para_mejorar_la_experiencia_de_usuario,_nos_gustaría_recopilar_estadísitcas_anónimas_sobre_las_funcionalidades_de_JabRef_que_usa._Sólo_se_registrará_qué_funcionalidades_emplea_y_con_qué_frecuencia._No_se_recopilará_ningún_dato_personal_ni_el_contenido_de_los_elementos_bibliográficos._Si_decide_permitir_la_recopilación_de_datos,_podrá_deshabilitarlo_posteriormente_en_Opciones_->_Preferencias_->General
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_fa.properties b/src/main/resources/l10n/JabRef_fa.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_fr.properties b/src/main/resources/l10n/JabRef_fr.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=Partager_anonymement_les_statistiques
 Telemetry\:_Help_make_JabRef_better=Télémétrie_:_contribue_à_l'amélioration_de_JabRef
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=Pour_améliorer_l'ergonomie_pour_l'utilisateur,_nous_souhaiterions_collecter_des_statistiques_anonymisées_sur_les_fonctionnalité_que_vous_utilisez._Nous_n'enregistrerons_que_les_fonctionnalités_que_vous_utilisés_et_leur_fréquence_d'utiliations._Nous_n'enregistrerons_jamais_des_données_personneles_ni_le_contenu_de_vos_entrées_bibliographiques._Si_vous_choisissez_d'autoriser_la_collecte_des_données,_vous_pourrez_plus_tard_l'interdire_via_Options_->_Préférences_->_Géneral.
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=Ce_fichier_a_été_trouvé_automatiquement._Voulez-vous_le_lier_à_cette_entrée_?
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_in.properties b/src/main/resources/l10n/JabRef_in.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_it.properties b/src/main/resources/l10n/JabRef_it.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=Condividi_statistiche_anonime
 Telemetry\:_Help_make_JabRef_better=Telemetria\:_Aiuta_a_migliorare_JabRef
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=Per_migliorare_l'esperienza_utente,_vorremmo_raccogliere_delle_statistiche_anonime_sulle_funzioni_che_usi._Registreremo_solo_quali_funzioni_accedi_e_quanto_spesso._Non_registreremo_dati_personali_né_il_contenuto_delle_voci_bibliografiche._Se_scegli_di_permettere_la_raccolta_dei_dati,_potrai_disabilitarla_successivamente_da_Opzioni_->_Preferenze_->_Generale.
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_ja.properties b/src/main/resources/l10n/JabRef_ja.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_nl.properties b/src/main/resources/l10n/JabRef_nl.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_no.properties b/src/main/resources/l10n/JabRef_no.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_pt_BR.properties b/src/main/resources/l10n/JabRef_pt_BR.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_ru.properties b/src/main/resources/l10n/JabRef_ru.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_sv.properties b/src/main/resources/l10n/JabRef_sv.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_tr.properties b/src/main/resources/l10n/JabRef_tr.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=Anonim_istatistikleri_paylaş
 Telemetry\:_Help_make_JabRef_better=Telemetri\:JabRef'i_daha_iyi_yapmaya_yardım_et
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=Kullanıcı_deneyimini_geliştirmek_için,_kullandığınız_özelliklerle_ilgili_anonim_istatistikleri_toplamak_istiyoruz._Yalnızca_kullandığınız_özellikleri_ve_kullanma_sıklığını_kaydedeceğiz._Kişisel_verileri_ya_da_bibliyografik_ögelerin_içeriğini_toplamayacağız._Eğer_veri_toplamaya_izin_vermeyi_seçerseniz,_bunu_daha_sonra_Seçenekler_->_Tercihler_aracılığıyla_etkisizleştirebilirsiniz_-
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=Bu_dosya_otomatik_olarak_bulundu._Bu_girdiye_bağlantılamak_ister_misiniz?
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_vi.properties b/src/main/resources/l10n/JabRef_vi.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/JabRef_zh.properties b/src/main/resources/l10n/JabRef_zh.properties
@@ -2331,3 +2331,4 @@ Share_anonymous_statistics=
 Telemetry\:_Help_make_JabRef_better=
 To_improve_the_user_experience,_we_would_like_to_collect_anonymous_statistics_on_the_features_you_use._We_will_only_record_what_features_you_access_and_how_often_you_do_it._We_will_neither_collect_any_personal_data_nor_the_content_of_bibliographic_items._If_you_choose_to_allow_data_collection,_you_can_later_disable_it_via_Options_->_Preferences_->_General.=
 This_file_was_found_automatically._Do_you_want_to_link_it_to_this_entry?=
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/main/resources/l10n/Menu_el.properties b/src/main/resources/l10n/Menu_el.properties
@@ -86,40 +86,31 @@ Write_XMP-metadata_to_PDFs=Εγγραφή_XMP-μεταδεδομένων_σε_PD
 Export_selected_entries=Εξαγωγή_επιλεγμένων_καταχωρήσεων
 
 Save_all=Αποθήκευση_όλων
-
 Manage_external_file_types=Διαχείριση_εξωτερικού_τυπου_αρχείων
-
 Open_file=Άνοιγμα_αρχείου
-
 Connect_to_external_SQL_database=Σύνδεση_σε_εξωτερική_βάση_SQL
 Export_to_external_SQL_database=Εξαγωγή_σε_εξωτερική_βάση_SQL
 Import_from_external_SQL_database=Εισαγωγή_σε_εξωτερική_βάση_SQL
 Focus_entry_table=Επικεντρωμένη_εισαγωγή_πίνακα
-
 Increase_table_font_size=&Μεγένθυση_γραμματοσειράς_πίνακα
 Decrease_table_font_size=&Σμίκρυνση_γραμματοσειράς_πίνακα
 Forward=Επόμενο
 Back=Πίσω
-
 Look_up_full_text_document=Εύρεση_πλήρες_κειμένο_εγγράφου
 Set/clear/rename_fields=Ρύθμιση/καθαρισμός/μετονομασία_πεδίων
-
 Resolve_duplicate_BibTeX_keys=Resolve_διπλότυπων_BibTeX_keys
 Copy_BibTeX_key_and_title=Αντιγραφή_BibTeX_και_τίτλου
-
 Cleanup_entries=Καθαρισμός_καταχωρήσεων
 Manage_keywords=Διαχείριση_λέξεων_κλειδιών
 Merge_entries=Συγχώνευση_καταχωρήσεων
 Open_folder=Άνοιγμα_φακέλου
 Find_unlinked_files...=Εύρεση_αποσυνδεμένων_αρχείων...
 Hide/show_toolbar=Απόκρυψη/προβολή_εργαλειοθήκης
-
 Fork_me_on_GitHub=Fork_me_on_GitHub
 Save_selected_as_plain_BibTeX...=Αποθήκευση_επιλεγμένου_ως_plain_BibTeX...
-
 Groups=Ομάδες
 Delete_entry=Διαγραφή_καταχώρησης
 Check_integrity=Έλεγχος_συνοχής
-
 Quality=Ποιότητα
 Online_help_forum=Online_forum_βοήθειας
+Names_are_not_in_the_standard_BibTeX_format.=
diff --git a/src/test/java/org/jabref/logic/integrity/IntegrityCheckTest.java b/src/test/java/org/jabref/logic/integrity/IntegrityCheckTest.java
@@ -163,8 +163,8 @@ public void testAuthorNameChecks() {
             // if run without mode, the NoBibtexFieldChecker will complain that "afterword" is a biblatex only field
             assertCorrect(withMode(createContext(field, ""), BibDatabaseMode.BIBLATEX));
             assertCorrect(withMode(createContext(field, "Knuth"), BibDatabaseMode.BIBLATEX));
-            assertCorrect(withMode(createContext(field, "   Knuth, Donald E. "), BibDatabaseMode.BIBLATEX));
-            assertCorrect(withMode(createContext(field, "Knuth, Donald E. and Kurt Cobain and A. Einstein"), BibDatabaseMode.BIBLATEX));
+            assertWrong(withMode(createContext(field, "   Knuth, Donald E. "), BibDatabaseMode.BIBLATEX));
+            assertWrong(withMode(createContext(field, "Knuth, Donald E. and Kurt Cobain and A. Einstein"), BibDatabaseMode.BIBLATEX));
             assertCorrect(withMode(createContext(field, "Donald E. Knuth and Kurt Cobain and A. Einstein"), BibDatabaseMode.BIBLATEX));
             assertWrong(withMode(createContext(field, ", and Kurt Cobain and A. Einstein"), BibDatabaseMode.BIBLATEX));
             assertWrong(withMode(createContext(field, "Donald E. Knuth and Kurt Cobain and ,"), BibDatabaseMode.BIBLATEX));
diff --git a/src/test/java/org/jabref/logic/integrity/PersonNamesCheckerTest.java b/src/test/java/org/jabref/logic/integrity/PersonNamesCheckerTest.java
@@ -0,0 +1,29 @@
+package org.jabref.logic.integrity;
+
+import java.util.Optional;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class PersonNamesCheckerTest {
+
+    PersonNamesChecker checker;
+
+    @Before
+    public void setUp() throws Exception {
+        checker = new PersonNamesChecker();
+    }
+
+    @Test
+    public void complainAboutPersonStringWithTwoManyCommas() throws Exception {
+        assertEquals(Optional.of("Names are not in the standard BibTeX format."),
+                checker.checkValue("Test1, Test2, Test3, Test4, Test5, Test6"));
+    }
+
+    @Test
+    public void doNotComplainAboutSecondNameInFront() throws Exception {
+        assertEquals(Optional.empty(), checker.checkValue("M. J. Gotay"));
+    }
+}
