Improve person names checker #2876
Conversation
tobiasdiez
added
the
status: ready-for-review
lenhard
left a comment
lenhard
left a comment
There was a problem hiding this comment.
Please fix the localization issues in the el localization file.
My other comment is just a suggestion that is up to you to decide.
| @@ -1,31 +1,30 @@ | |||
| #! | |||
There was a problem hiding this comment.
It seems that something went wrong when merging the language file here? Why is there a file header? Also, why are some of the localizations removed?
| AuthorList authorList = AuthorList.parse(value); | ||
| if (!authorList.getAsLastFirstNamesWithAnd(false).equals(value) | ||
| && !authorList.getAsFirstLastNamesWithAnd().equals(value)) { | ||
| return Optional.of(Localization.lang("Names are not in the standard BibTeX format.")); |
There was a problem hiding this comment.
Should we drop a hint here what the expected format actually is? Otherwise, the user might be left wondering what he should do to fix the warning.
There was a problem hiding this comment.
I agree that the error message is not very detailed and leaves room for interpretation. However, since the check issues are reported in table form a very concise error message is required. Thus for now I don't see an easy way to improve it.
tobiasdiez
force-pushed
the
improvePersonNamesChecker
branch
from
3314a6e to
2473e19
Compare
* upstream/master: Greek Translation (#2835) Updated JabRef_tr.properties (#2894) Display deprecated fields in single-column layout Improve performance of entry editor (#2892) Improve person names checker (#2876) Fix #2871: all field editors have maximal height and width Fix #2880: NPE when importing in a database without groups Updated Menu_tr.properties (#2884) Updated JabRef_tr.properties (#2883) Updated mysql-connector-java from 5.1.40 -> 5.1.42 Updated java-string-similarity from 0.23 -> 0.24 Add small change to push build again # Conflicts: # external-libraries.txt
The integrity check now also tests that names are in BibTeX format.
gradle localizationUpdate?