Open recent library command yields many IllegalStateExceptions

[kbarros]

When executed, the menu item File -> Recent libraries -> mylibrary.bib will produce a giant stack of java.lang.IllegalStateException dialog windows. However, after closing all these dialog windows, the library mylibrary.bib does seem to open correctly. Full stack trace below.

JabRef 5.0-dev--snapshot--2019-05-01--master--f1b4b5be3
Mac OS X 10.14.4 x86_64
Java 1.8.0_212

	at com.sun.glass.ui.Application.checkEventThread(Application.java:443)
	at com.sun.glass.ui.MenuItem.<init>(MenuItem.java:64)
	at com.sun.glass.ui.Application.createMenuItem(Application.java:619)
	at com.sun.glass.ui.Application.createMenuItem(Application.java:614)
	at com.sun.glass.ui.Application.createMenuItem(Application.java:609)
	at com.sun.javafx.tk.quantum.GlassSystemMenu.insertMenuItem(GlassSystemMenu.java:251)
	at com.sun.javafx.tk.quantum.GlassSystemMenu.lambda$insertMenu$345(GlassSystemMenu.java:169)
	at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:329)
	at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73)
	at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233)
	at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482)
	at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541)
	at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205)
	at javafx.collections.ModifiableObservableListBase.add(ModifiableObservableListBase.java:155)
	at com.sun.javafx.scene.control.GlobalMenuAdapter.insertItem(GlobalMenuAdapter.java:134)
	at com.sun.javafx.scene.control.GlobalMenuAdapter.access$100(GlobalMenuAdapter.java:54)
	at com.sun.javafx.scene.control.GlobalMenuAdapter$2.onChanged(GlobalMenuAdapter.java:106)
	at com.sun.javafx.collections.ListListenerHelper$Generic.fireValueChangedEvent(ListListenerHelper.java:329)
	at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73)
	at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233)
	at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482)
	at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541)
	at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205)
	at javafx.collections.ModifiableObservableListBase.add(ModifiableObservableListBase.java:155)
	at java.util.AbstractList.add(AbstractList.java:108)
	at org.jabref.gui.menus.FileHistoryMenu.addItem(FileHistoryMenu.java:58)
	at org.jabref.gui.menus.FileHistoryMenu.setItems(FileHistoryMenu.java:50)
	at org.jabref.gui.menus.FileHistoryMenu.newFile(FileHistoryMenu.java:43)
	at org.jabref.gui.importer.actions.OpenDatabaseAction.openFiles(OpenDatabaseAction.java:168)
	at org.jabref.gui.importer.actions.OpenDatabaseAction.openFile(OpenDatabaseAction.java:119)
	at org.jabref.gui.menus.FileHistoryMenu.lambda$openFile$398(FileHistoryMenu.java:74)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

[Siedlerchr]

Hm, this seems to be some weird mac issue again. On Windows 10 this is not a problem
Edit// Looks like a threading issue

[Siedlerchr]

@kbarros I think I found the issue. Could you please test this version here and report back if it works for you? https://builds.jabref.org/fixFileHistoryMac/

[Siedlerchr]

Should be fixed now in master as well.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

[kbarros]

I can confirm that this new version works for me.

JabRef 5.0-dev--snapshot--2019-05-03--master--99d99cf02
Mac OS X 10.14.4 x86_64
Java 1.8.0_212