drag and drop file into file field in entry editor throws exception

[ilippert]

JabRef 5.0-dev (latest snap release)
Linux 5.1.5-300.fc30.x86_64 amd64
Java 1.8.0_212

Steps to reproduce:

drag and drop file into file field in entry editor

Paste your log details here.

Detail information:

Uncaught exception occurred in Thread[JavaFX Application Thread,5,main]
java.lang.NullPointerException
at javafx.scene.Scene$DnDGesture.access$6000(Scene.java:2909)
at javafx.scene.Scene$DropTargetListener.drop(Scene.java:2876)
at com.sun.javafx.tk.quantum.GlassSceneDnDEventHandler.lambda$handleDragDrop$226(GlassSceneDnDEventHandler.java:95)
at java.security.AccessController.doPrivileged(Native Method)
at com.sun.javafx.tk.quantum.GlassSceneDnDEventHandler.handleDragDrop(GlassSceneDnDEventHandler.java:92)
at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleDragDrop$309(GlassViewEventHandler.java:672)
at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:389)
at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleDragDrop(GlassViewEventHandler.java:671)
at com.sun.glass.ui.View.handleDragDrop(View.java:712)
at com.sun.glass.ui.View.notifyDragDrop(View.java:1037)
at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
at com.sun.glass.ui.gtk.GtkApplication.lambda$null$450(GtkApplication.java:139)
at java.lang.Thread.run(Thread.java:748)

</details>

[ilippert]

also, maybe this is a different bug(?), the file dragged onto the file field is renamed and stays in the origin folder, and a copy of the not-renamed file is saved within the default file folder of jabref.

my perception is as follows:

drag & drop onto file field renames the file and keeps this renamed file in the original folder. (fine).
the not-renamed file is copied into the default file folder.

thus, after this operation, two files exist.

[ilippert]

this is from an up to date snap version on fedora 30
drag and drop of file onto a file field in entry editor still produces this exception:

sorry for tagging you, @tobiasdiez I am not sure whether this issue old has fallen of the radar ;) would be great to know if you need any more information to serve the community approaching this.

Detail information:

java.lang.NullPointerException at javafx.scene.Scene$DnDGesture.access$6000(Scene.java:2909) at javafx.scene.Scene$DropTargetListener.drop(Scene.java:2876) at com.sun.javafx.tk.quantum.GlassSceneDnDEventHandler.lambda$handleDragDrop$226(GlassSceneDnDEventHandler.java:95) at java.security.AccessController.doPrivileged(Native Method) at com.sun.javafx.tk.quantum.GlassSceneDnDEventHandler.handleDragDrop(GlassSceneDnDEventHandler.java:92) at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleDragDrop$309(GlassViewEventHandler.java:672) at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:389) at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleDragDrop(GlassViewEventHandler.java:671) at com.sun.glass.ui.View.handleDragDrop(View.java:712) at com.sun.glass.ui.View.notifyDragDrop(View.java:1037) at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method) at com.sun.glass.ui.gtk.GtkApplication.lambda$null$450(GtkApplication.java:139) at java.lang.Thread.run(Thread.java:748)

[Siedlerchr]

This might be a problem with the snap functionality and the interaction with the file system.
Maybe @LyzardKing can reproduce this error?
However, I am unsure if we can do anything about this, as the error is coming directly from the java run time classes.

[ilippert]

thanks for looking into this! interestingly, when using the + button next to the file field in the entry editor, the file selection window interacts well with nautilus

[Siedlerchr]

I will try to test this with Ubuntu in my VM and a snap, see if I get the same error

[LyzardKing]

Hi.
I tried now on ubuntu 19.04 with the updated snap.. the drag and drop feature works..
EDIT: also, my files are never moved/renamed automatically, unless I use the cleanup function to do so

[LyzardKing]

@Siedlerchr Have you done any more testing?

[Siedlerchr]

@LyzardKing Jus tested it. Works fine under Ubuntu 18.04
Just one thing, I get a message in console that the snap java version is 8u60 although my global runtime is 1.8.0_171.

Do snaps ship with their own jre/jdk version?

Jul 12, 2019 8:37:07 AM javafx.fxml.FXMLLoader$ValueElement processValue
WARNING: Loading FXML document with JavaFX API of version 8.0.112 by JavaFX runtime of version 8.0.60

[LyzardKing]

The snap has it's own jdk/jre version, which is the one from the ubuntu 16.04 repos.
it should be 8u212-b03-0ubuntu1.16.04.1 according to packages.ubuntu.com
8u60 is the version of openjfx.
When I last tested the snap it would not work with 18.04 as a source. But I test it every once in a while to see if it works with the later versions of openjfx