Tests of BibEntry and BibDatabase

[oscargus]

Added more tests and fixed a few issues.

Fixed(?) a Coverity issue in AboutDialog.

[Siedlerchr]

Is the StandardCharset really ISO and not UTF of that file?

[oscargus]

I see now that the encoding is stated as UTF in the file. However since ISO is the first code page of UTF it is hard to actually determine the difference here... (And if I'm not wrong US_ASCII would also have worked for this file...)

I'll change it if there are other things to change as it is working and is sort of correct.

[oscargus]

I've fixed all(?) comments. One thing happened though. What is the difference between the two BibEntry under test here? (The test shouldn't look like this, but I kept both for now.)

    @Test
    @Ignore
    public void getFieldOrAliasDateWithYearNumericalMonth() {
        Assert.assertEquals("2003-03",
                (BibtexParser.singleFromString("@ARTICLE{HipKro03, year = {2003}, month = 3 }")).getFieldOrAlias("date"));
        emptyEntry.setField("year", "2003");
        emptyEntry.setField("month", "#3#");
        Assert.assertEquals("2003-03", emptyEntry.getFieldOrAlias("date"));
    }

The first assertion passes, but not the second. Seems to be something with the parser?

[tobiasdiez]

What happens if you remove the # in the month field?

[oscargus]

Then it works, but that is a different test case. (I was surprised that the original test case worked, I only saw it in another test a few lines above.)

[oscargus]

I have the other test case getFieldOrAliasDateWithYearNumericalMonthString

[tobiasdiez]

But #3# is not a valid month format, or is it? as getFieldOrAliasDateWithYearAbbreviatedMonth works, I don't see a problem here.

[oscargus]

Maybe there isn't a problem. However, if the corresponding statement was in a .bib-file it would apparently be parsed as 3 and not #3# . I remove that test then.