Skip to content

Remove telemetry #11389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2024
Merged

Remove telemetry #11389

merged 3 commits into from
Jun 18, 2024

Conversation

@calixtus
Copy link
Member

@calixtus calixtus commented Jun 18, 2024

follow up to #11342 (comment)

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 18, 2024
@calixtus
Merge remote-tracking branch 'refs/remotes/upstream/main' into remove…
4d804a4 
…-telemetry

# Conflicts:
#	src/main/java/org/jabref/gui/telemetry/Telemetry.java
koppor
koppor previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"telemetry" not found in the code. Thus, good to go!

@koppor koppor enabled auto-merge June 18, 2024 12:20
@calixtus
Copy link
Member Author

calixtus commented Jun 18, 2024

forgot the localization

@calixtus calixtus disabled auto-merge June 18, 2024 12:21
@calixtus calixtus enabled auto-merge June 18, 2024 12:23
koppor
koppor approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My find just checked "*.java" 😅

@calixtus calixtus added this pull request to the merge queue Jun 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 50c3efc Jun 18, 2024
@calixtus calixtus deleted the remove-telemetry branch June 18, 2024 12:40
@koppor koppor mentioned this pull request Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixtus @koppor