fix arxiv html download redirect #11797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
Member
|
Tested with |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Siedlerchr
commented
Sep 20, 2024
| urlToCheck = locationHeader; | ||
| } | ||
| // while loop, because there could be multiple redirects | ||
| } while (StringUtil.isNullOrEmpty(locationHeader)); |
Member
Author
There was a problem hiding this comment.
we need to set a limit to max redirects ...
Member
|
I am kind of fighting with Wiremock... -- currently getting 404 at org.jabref.gui.linkedfile.DownloadLinkedFileActionTest#removesHtmlFileLink |
…xivHtmlImport * upstream/fixArxivHtmlImport: Fix condition Improve test names Use Wiremock instead of real endpoint Simplyfiy code Fix conditions
…xArxivHtmlImport * 'fixArxivHtmlImport' of github.com:JabRef/jabref: Fix focus for keywords and crossref fields (#11792) Fix ai chat not on fx thread (#11796) [AI] Add more uses statements (#11788) Update djl api dependency (#11787) Improve pdf content parser for DOIs (#11782) minor refactor to JabRefDialogService (#11767) Add more OS-dependent context to panel freeze dev documentation. (#11781)
Member
Author
|
Isidore fetcher returns two different entries... and IEEE gives bad gateway |
koppor
reviewed
Sep 20, 2024
src/test/java/org/jabref/gui/linkedfile/DownloadLinkedFileActionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/gui/linkedfile/DownloadLinkedFileActionTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
koppor
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4913
We encountered a 301 redirect and thus content type was html
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)