Skip to content

Refactor the isUnwantedText #12369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2025
Merged

Refactor the isUnwantedText #12369

merged 4 commits into from
Jan 10, 2025

Conversation

@leaf-soba
Copy link
Contributor

@leaf-soba leaf-soba commented Jan 9, 2025

  1. Add comment
  2. minor refactor

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@leaf-soba
Refactor the IsFarAway
7b5d3a3 
1. Add comment
2. minor refactor
@leaf-soba leaf-soba changed the title Refactor the IsFarAway Refactor the isUnwantedText Jan 9, 2025
@leaf-soba
remove extra space
9aa228a 
remove extra space
@leaf-soba
remove unnecessary quote
7507d13 
remove unnecessary quote
@Siedlerchr Siedlerchr enabled auto-merge January 10, 2025 16:27
@Siedlerchr Siedlerchr added this pull request to the merge queue Jan 10, 2025
Merged via the queue into JabRef:main with commit 2cd83df Jan 10, 2025
Siedlerchr added a commit that referenced this pull request Jan 12, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into downgradeRunnerImage
7cfb793 
* upstream/main:
  Refactor the isUnwantedText (#12369)
  Searching for entries with empty field (#12376)
  Downgrade Ubuntu (#12375)
Siedlerchr added a commit to ar-rana/jabref that referenced this pull request Jan 13, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into feature/arXivId
0308a0b 
* upstream/main: (29 commits)
  Bump org.glassfish.jersey.containers:jersey-container-grizzly2-http (JabRef#12384)
  Bump src/main/resources/csl-styles from `080516e` to `6bae16d` (JabRef#12387)
  Bump src/main/resources/csl-locales from `96d704d` to `9914965` (JabRef#12386)
  Bump buildres/abbrv.jabref.org from `93a2cad` to `e74e6eb` (JabRef#12385)
  Bump org.openrewrite.rewrite from 6.29.3 to 7.0.0 (JabRef#12383)
  Bump org.glassfish.jersey.core:jersey-server from 3.1.9 to 3.1.10 (JabRef#12381)
  Bump org.glassfish.jersey.test-framework.providers:jersey-test-framework-provider-grizzly2 (JabRef#12380)
  fix linux build not updated
  Refactor the isUnwantedText (JabRef#12369)
  Searching for entries with empty field (JabRef#12376)
  Downgrade Ubuntu (JabRef#12375)
  Downgrade Ubuntu
  Fix main table sorting (JabRef#12371)
  fix bib and pdf name (JabRef#12366)
  use v4 instead of master
  Update abbrv.jabref.org (JabRef#12365)
  Bump buildres/abbrv.jabref.org from `78e1b08` to `c202741` (JabRef#12363)
  Bump org.beryx.jlink from 3.1.0-rc-1 to 3.1.1 (JabRef#12362)
  Bump tech.units:indriya from 2.2.1 to 2.2.2 (JabRef#12361)
  Bump com.dlsc.gemsfx:gemsfx from 2.80.0 to 2.81.0 (JabRef#12360)
  ...

# Conflicts:
#	buildres/abbrv.jabref.org
#	src/main/resources/csl-styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leaf-soba @Siedlerchr