Skip to content

Fix no such element exception in copy to #12488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix no such element exception in copy to #12488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
301d0f3
Fix np such element exception in copy tp
Siedlerchr Feb 10, 2025
568f230
fix checkstyle
Siedlerchr Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/main/java/org/jabref/gui/maintable/RightClickMenu.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.jabref.gui.maintable;

import java.nio.file.Path;
import java.util.Optional;

import javax.swing.undo.UndoManager;
Expand Down Expand Up @@ -120,27 +119,31 @@ private static Menu createCopyToMenu(ActionFactory factory,
StateManager stateManager,
GuiPreferences preferences,
LibraryTab libraryTab,
ImportHandler importHandler
) {
ImportHandler importHandler) {
Menu copyToMenu = factory.createMenu(StandardActions.COPY_TO);

ObservableList<BibDatabaseContext> openDatabases = stateManager.getOpenDatabases();

BibDatabaseContext sourceDatabaseContext = libraryTab.getBibDatabaseContext();

Optional<Path> sourcePath = libraryTab.getBibDatabaseContext().getDatabasePath();
String sourceDatabaseName = FileUtil.getUniquePathFragment(stateManager.collectAllDatabasePaths(), sourcePath.get()).get();
Optional<String> sourceDatabaseName = libraryTab
.getBibDatabaseContext().getDatabasePath().stream()
.flatMap(path -> FileUtil.getUniquePathFragment(stateManager.collectAllDatabasePaths(), path).stream())
.findFirst();

if (!openDatabases.isEmpty()) {
openDatabases.forEach(bibDatabaseContext -> {
Optional<String> destinationPath = Optional.empty();
String destinationDatabaseName = "";

if (bibDatabaseContext.getDatabasePath().isPresent()) {
destinationDatabaseName = FileUtil.getUniquePathFragment(stateManager.collectAllDatabasePaths(), bibDatabaseContext.getDatabasePath().get()).get();
if (destinationDatabaseName.equals(sourceDatabaseName)) {
Optional<String> uniqueFilePathFragment = FileUtil.getUniquePathFragment(stateManager.collectAllDatabasePaths(), bibDatabaseContext.getDatabasePath().get());
if (uniqueFilePathFragment.equals(sourceDatabaseName)) {
return;
}
if (uniqueFilePathFragment.isPresent()) {
destinationDatabaseName = uniqueFilePathFragment.get();
}
} else if (bibDatabaseContext.getLocation() == DatabaseLocation.SHARED) {
destinationDatabaseName = bibDatabaseContext.getDBMSSynchronizer().getDBName() + " [" + Localization.lang("shared") + "]";
} else {
Expand Down