Skip to content

Conversation

@paudelritij
Copy link
Contributor

@paudelritij paudelritij commented Mar 29, 2025

Closes #12843

This pull request addresses an issue where the dialog prompting users about including cross-references reappears even after the user has selected the "Do not ask again" option. Additionally, it resolves the problem of the updated state of preferences not being saved correctly, ensuring that the last saved state persists across sessions.

  • Use EasyBind.listen() in getCopyToPreferences to observe any change in these properties to save the preferences.
  • Implemented property binding in CopyToPreferences class.

Screen Recordings:

sub-issue-1.mov
sub-issue-2.mov

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@subhramit
Copy link
Member

Screen recordings, please?

Copy link
Member

@subhramit subhramit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@trag-bot
Copy link

trag-bot bot commented Mar 30, 2025

@trag-bot didn't find any issues in the code! ✅✨

@subhramit subhramit added this pull request to the merge queue Apr 1, 2025
Merged via the queue into JabRef:main with commit 971f23a Apr 1, 2025
1 check passed
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this pull request May 2, 2025
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix "Copy to" preferences

2 participants