-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Migrate CLI handling from Apache Commons CLI to PicoCLI #13012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
JabKit: Only support check-consistency. Change interface. https://clig.dev/#arguments-and-flags Maybe Example: |
| Successfully\ embedded\ metadata\ on\ at\ least\ one\ linked\ file\ of\ %0.=Successfully embedded metadata on at least one linked file of %0. | ||
| Successfully\ written\ XMP\ metadata\ of\ at\ least\ one\ entry\ to\ %0.=Successfully written XMP metadata of at least one entry to %0. | ||
| Successfully\ written\ XMP\ metadata\ on\ at\ least\ one\ linked\ file\ of\ %0.=Successfully written XMP metadata on at least one linked file of %0. | ||
| The\ following\ providers\ are\ available\:=The following providers are available: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 2913 says Available export formats: - shouldn't it be Available providers: here?
| You\ must\ specify\ an\ identifier.=You must specify an identifier. | ||
| You\ must\ specify\ one\ (or\ more)\ citations.=You must specify one (or more) citations. | ||
| # CommandLine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use JabKit here?
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
Second review pending... |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
JabRef/jabref#13012 Move Method private writeMetadataToPDFsOfEntry(databaseContext BibDatabaseContext, citeKey String, entry BibEntry, filePreferences FilePreferences, xmpPdfExporter XmpPdfExporter, embeddedBibFilePdfExporter EmbeddedBibFilePdfExporter, abbreviationRepository JournalAbbreviationRepository, writeXMP boolean, embedBibfile boolean) : void from class org.jabref.cli.ArgumentProcessor to private writeMetadataToPDFsOfEntry(databaseContext BibDatabaseContext, citeKey String, entry BibEntry, filePreferences FilePreferences, xmpPdfExporter XmpPdfExporter, embeddedBibFilePdfExporter EmbeddedBibFilePdfExporter, abbreviationRepository JournalAbbreviationRepository, writeXMP boolean, embedBibfile boolean) : void from class org.jabref.cli.PdfUpdate
|
Bug report from forum: Unknown option "--importToOpen" it was |
Follow-up to #12990
Refs #7510, #110
Docs issue JabRef/user-documentation#562
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)