Skip to content

Conversation

@calixtus
Copy link
Member

@calixtus calixtus commented Jul 4, 2025

Follow up to #12990

Steps to test

Test with gradle

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus changed the title Main architecture test Bring back MainArchitectureTest Jul 4, 2025
@calixtus calixtus added the dev: code-quality Issues related to code or architecture decisions label Jul 4, 2025
calixtus and others added 2 commits July 4, 2025 17:55
Fix architecture tests

Co-authored-by: Oliver Kopp <[email protected]>
@calixtus calixtus added the automerge PR is tagged with that label will be merged if workflows are green label Jul 4, 2025
@jabref-machine
Copy link
Collaborator

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of [x] (done), [ ] (not done yet) or [/] (not applicable).

@calixtus calixtus enabled auto-merge July 4, 2025 16:20
koppor
koppor previously approved these changes Jul 4, 2025
@calixtus calixtus added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
koppor
koppor previously approved these changes Jul 4, 2025
@jabref-machine
Copy link
Collaborator

Your pull request needs to link an issue correctly.

To ease organizational workflows, please link this pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue:

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message.

Examples

  • Fixes #xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes https://github.com/JabRef/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes https://github.com/Koppor/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes [#xyz](https://github.com/JabRef/jabref/issues/xyz) links pull-request to issue. Merging the PR will NOT close the issue.

@koppor koppor added dev: no-bot-comments If set, there should be no comments from our bots and removed automerge PR is tagged with that label will be merged if workflows are green labels Jul 4, 2025
Co-authored-by: Oliver Kopp <[email protected]>
@trag-bot
Copy link

trag-bot bot commented Jul 4, 2025

@trag-bot didn't find any issues in the code! ✅✨

@calixtus calixtus added this pull request to the merge queue Jul 4, 2025
Merged via the queue into JabRef:main with commit e29044c Jul 4, 2025
1 check passed
@calixtus calixtus deleted the MainArchitectureTest branch July 4, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: architecture dev: code-quality Issues related to code or architecture decisions dev: no-bot-comments If set, there should be no comments from our bots dev: testing Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants