Fix authors UTF8 display #1954
Merged
Fix authors UTF8 display #1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert tabs to spaces
Resolve conflict
|
I tried the installer and for me it looks good: |
Siedlerchr
added
the
status: ready-for-review
|
Good news! It works! Could you please change in DEVELOPERS file Joerg Lenhard to Jörg (to make it perfect). JabRef 3.7dev--snapshot--2016-09-11--gradleEncoding--1581dd9 |
|
Code LGTM. |
This was referenced Sep 11, 2016
5 tasks
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
* Add filteringCharset = 'UTF-8' Convert tabs to spaces * Read properties file with UTF8 encoding * Joerg->Jörg * Unified spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I tested all kind of changes locally and it worked.
Even inside Eclipse it showed the correct names
Followup from #1945
@grimes2 Could you please test the changes, too?
In a couple of minutes hopefully the new version is online when travis passes
http://builds.jabref.org/gradleEncoding/