Fixing bug 1282

[igorsteinmacher]

Duplicate PR #59

[koppor]

Is this a clean version of #59? Should we close #59 and concentrate on this one?

[koppor]

The thing is, we want to improve our code quality. Could you use a formatter as described in CONTRIBUTING.md? May I also ask to remove commit a6919e6 from here as it has nothing to do with this PR? You can open a separate PR for updating the translation :). Sorry for being picky, but we are really trying to improve our code quality.

[igorsteinmacher]

OK Oliver,
I will format the code accordingly and remove the commit from the PR

Igor Fabio Steinmacher, Ph.D.
Professor in Dept. of Computing at Universidade Tecnológica Federal do
Paraná

On Thu, Oct 1, 2015 at 6:42 PM, Oliver Kopp [email protected]
wrote:

The thing is, we want to improve our code quality. Could you use a
formatter as described in CONTRIBUTING.md? May I also ask to remove commit
a6919e6
a6919e6
from here as it has nothing to do with this PR? You can open a separate PR
for updating the translation :). Sorry for being picky, but we are really
trying to improve our code quality.

—
Reply to this email directly or view it on GitHub
#198 (comment).

[simonharrer]

Looks good to me.

[stefan-kolb]

I would love to see a comment here why this is necessary. So future developers can instantly see the reason behind this code and remove it if behaviour has changed.

[koppor]

Last thing: Could you add a CHANGELOG entry? 😇

[igorsteinmacher]

Did it.
OK! A long time I didn't send anything myself. I agree that I need to follow the process and practices, and I did not read them after returning... Hope this is good to go @koppor